From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755462AbcK1V0g (ORCPT ); Mon, 28 Nov 2016 16:26:36 -0500 Received: from mga03.intel.com ([134.134.136.65]:28009 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754172AbcK1V02 (ORCPT ); Mon, 28 Nov 2016 16:26:28 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,565,1473145200"; d="scan'208";a="791828793" Date: Mon, 28 Nov 2016 14:26:26 -0700 From: Ross Zwisler To: Nicolas Iooss Cc: Dan Williams , linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] libnvdimm, namespace: fix the type of name variable Message-ID: <20161128212626.GB16225@linux.intel.com> References: <20161126191804.21349-1-nicolas.iooss_linux@m4x.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161126191804.21349-1-nicolas.iooss_linux@m4x.org> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 26, 2016 at 08:18:04PM +0100, Nicolas Iooss wrote: > In create_namespace_blk(), the local variable "name" is defined as an > array of NSLABEL_NAME_LEN pointers: > > char *name[NSLABEL_NAME_LEN]; > > This variable is then used in calls to memcpy() and kmemdup() as if it > were char[NSLABEL_NAME_LEN]. Remove the star in the variable definition > to makes it look right. > > Signed-off-by: Nicolas Iooss Yep, nice catch. Reviewed-by: Ross Zwisler