From: "Matias Bjørling" <m@bjorling.me>
To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: axboe@fb.com, "Matias Bjørling" <m@bjorling.me>
Subject: [PATCH 01/23] nvme: lightnvm: frees wrong cmd structure
Date: Mon, 28 Nov 2016 22:38:52 +0100 [thread overview]
Message-ID: <20161128213914.12516-2-m@bjorling.me> (raw)
In-Reply-To: <20161128213914.12516-1-m@bjorling.me>
When struct nvme_request was introduced, the nvme_nvm_submit_io was
converted to the new interface. The interface moves nvme_nvm_command
data structure into the struct request pdu. On io completion, rq->cmd is
freed, which should have been the dereferenced pdu nvme_request->cmd.
Fixes: d49187e97e94 "nvme: introduce struct nvme_request"
Signed-off-by: Matias Bjørling <m@bjorling.me>
---
drivers/nvme/host/lightnvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
index 442f677..de3dc87 100644
--- a/drivers/nvme/host/lightnvm.c
+++ b/drivers/nvme/host/lightnvm.c
@@ -477,7 +477,7 @@ static void nvme_nvm_end_io(struct request *rq, int error)
rqd->ppa_status = nvme_req(rq)->result.u64;
nvm_end_io(rqd, error);
- kfree(rq->cmd);
+ kfree(nvme_req(rq)->cmd);
blk_mq_free_request(rq);
}
--
2.9.3
next prev parent reply other threads:[~2016-11-28 21:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 21:38 [PATCH 00/23] LightNVM patches for 4.10 Matias Bjørling
2016-11-28 21:38 ` Matias Bjørling [this message]
2016-11-28 21:38 ` [PATCH 02/23] nvme: lightnvm: attach lightnvm sysfs to nvme block device Matias Bjørling
2016-11-28 21:38 ` [PATCH 03/23] lightnvm: enable to send hint to erase command Matias Bjørling
2016-11-28 21:38 ` [PATCH 04/23] lightnvm: do not protect block 0 Matias Bjørling
2016-11-28 21:38 ` [PATCH 05/23] lightnvm: export set bad block table Matias Bjørling
2016-11-28 21:38 ` [PATCH 06/23] lightnvm: add ECC error codes Matias Bjørling
2016-11-28 21:38 ` [PATCH 07/23] lightnvm: rrpc: split bios of size > 256kb Matias Bjørling
2016-11-28 21:38 ` [PATCH 08/23] lightnvm: remove sysfs configuration interface Matias Bjørling
2016-11-28 21:39 ` [PATCH 09/23] lightnvm: cleanup unused target operations Matias Bjørling
2016-11-28 21:39 ` [PATCH 10/23] lightnvm: make address conversion functions global Matias Bjørling
2016-11-28 21:39 ` [PATCH 11/23] lightnvm: remove unnecessary variables in rrpc Matias Bjørling
2016-11-28 21:39 ` [PATCH 12/23] lightnvm: use constant name instead of value Matias Bjørling
2016-11-28 21:39 ` [PATCH 13/23] lightnvm: remove gen_lun abstraction Matias Bjørling
2016-11-28 21:39 ` [PATCH 14/23] lightnvm: manage lun partitions internally in mm Matias Bjørling
2016-11-28 21:39 ` [PATCH 15/23] lightnvm: move block provisioning to targets Matias Bjørling
2016-11-28 21:39 ` [PATCH 16/23] lightnvm: remove get_lun operation on gennvm Matias Bjørling
2016-11-28 21:39 ` [PATCH 17/23] lightnvm: remove debug lun statistics from gennvm Matias Bjørling
2016-11-28 21:39 ` [PATCH 18/23] lightnvm: eliminate nvm_block abstraction on mm Matias Bjørling
2016-11-28 21:39 ` [PATCH 19/23] lightnvm: eliminate nvm_lun abstraction in mm Matias Bjørling
2016-11-28 21:39 ` [PATCH 20/23] lightnvm: introduce helpers for generic ops in rrpc Matias Bjørling
2016-11-28 21:39 ` [PATCH 21/23] lightnvm: introduce max_phys_sects helper function Matias Bjørling
2016-11-28 21:39 ` [PATCH 22/23] lightnvm: use target nvm on target-specific ops Matias Bjørling
2016-11-28 21:39 ` [PATCH 23/23] lightnvm: transform target get/set bad block Matias Bjørling
2016-11-29 20:00 ` [PATCH 00/23] LightNVM patches for 4.10 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128213914.12516-2-m@bjorling.me \
--to=m@bjorling.me \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®