From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932839AbcK3BiY (ORCPT ); Tue, 29 Nov 2016 20:38:24 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:39388 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754020AbcK3BiO (ORCPT ); Tue, 29 Nov 2016 20:38:14 -0500 Date: Tue, 29 Nov 2016 20:38:01 -0500 (EST) Message-Id: <20161129.203801.926114791600466509.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: andreyknvl@google.com, gerrit@erg.abdn.ac.uk, dccp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dvyukov@google.com, kcc@google.com, edumazet@google.com, syzkaller@googlegroups.com Subject: Re: [PATCH net] net/dccp: fix use-after-free in dccp_invalid_packet From: David Miller In-Reply-To: <1480343209.18162.50.camel@edumazet-glaptop3.roam.corp.google.com> References: <1480343209.18162.50.camel@edumazet-glaptop3.roam.corp.google.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Nov 2016 16:38:39 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Mon, 28 Nov 2016 06:26:49 -0800 > From: Eric Dumazet > > pskb_may_pull() can reallocate skb->head, we need to reload dh pointer > in dccp_invalid_packet() or risk use after free. > > Bug found by Andrey Konovalov using syzkaller. > > Signed-off-by: Eric Dumazet > Reported-by: Andrey Konovalov Applied and queued up for -stable, thanks Eric.