From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
nm@ti.com, Viresh Kumar <vireshk@kernel.org>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
robh@kernel.org, d-gerlach@ti.com, broonie@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH V4 10/10] PM / OPP: Don't assume platform doesn't have regulators
Date: Mon, 28 Nov 2016 17:18:10 -0800 [thread overview]
Message-ID: <20161129011810.GW6095@codeaurora.org> (raw)
In-Reply-To: <82cc855c7abb5d0583abe4cc9132c7e589434814.1479986492.git.viresh.kumar@linaro.org>
On 11/24, Viresh Kumar wrote:
> If the regulators aren't set explicitly by the platform, the OPP core
> assumes that the platform doesn't have any regulator and uses the
> clk-only callback.
>
> If the platform failed to register a regulator with the core, then this
> can turn out to be a dangerous assumption as the OPP core will try to
> change clk without changing regulators.
>
> Handle that properly by making sure that the DT didn't have any entries
> for supply voltages as well.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-29 1:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 11:36 [PATCH V4 00/10] PM / OPP: Multiple regulator support Viresh Kumar
2016-11-24 11:36 ` [PATCH V4 01/10] PM / OPP: Fix incorrect cpu-supply property in binding Viresh Kumar
2016-11-24 11:36 ` [PATCH V4 02/10] PM / OPP: Reword binding supporting multiple regulators per device Viresh Kumar
2016-11-24 11:36 ` [PATCH V4 03/10] PM / OPP: Don't use OPP structure outside of rcu protected section Viresh Kumar
2016-11-29 0:57 ` Stephen Boyd
2016-11-24 11:36 ` [PATCH V4 04/10] PM / OPP: Manage supply's voltage/current in a separate structure Viresh Kumar
2016-11-29 0:58 ` Stephen Boyd
2016-11-24 11:36 ` [PATCH V4 05/10] PM / OPP: Pass struct dev_pm_opp_supply to _set_opp_voltage() Viresh Kumar
2016-11-29 0:59 ` Stephen Boyd
2016-11-24 11:36 ` [PATCH V4 06/10] PM / OPP: Add infrastructure to manage multiple regulators Viresh Kumar
2016-11-29 0:55 ` Stephen Boyd
2016-11-24 11:36 ` [PATCH V4 07/10] PM / OPP: Separate out _generic_opp_set_rate() Viresh Kumar
2016-11-29 1:09 ` Stephen Boyd
2016-11-24 11:36 ` [PATCH V4 08/10] PM / OPP: Allow platform specific custom set_opp() callbacks Viresh Kumar
2016-11-29 1:16 ` Stephen Boyd
2016-11-24 11:36 ` [PATCH V4 09/10] PM / OPP: Don't WARN on multiple calls to dev_pm_opp_set_regulators() Viresh Kumar
2016-11-24 11:36 ` [PATCH V4 10/10] PM / OPP: Don't assume platform doesn't have regulators Viresh Kumar
2016-11-29 1:18 ` Stephen Boyd [this message]
2016-11-28 13:41 ` [PATCH V4 00/10] PM / OPP: Multiple regulator support Viresh Kumar
2016-11-28 13:45 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129011810.GW6095@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=broonie@kernel.org \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome