From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756641AbcK2ODl (ORCPT <rfc822;w@1wt.eu>);
        Tue, 29 Nov 2016 09:03:41 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:40260 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755099AbcK2ODd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 Nov 2016 09:03:33 -0500
Date: Tue, 29 Nov 2016 15:03:43 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: csmanjuvijay@gmail.com
Cc: Arnd Bergmann <arnd@arndb.de>, Vladimir Zapolskiy <vz@mleia.com>,
        Sylvain Lemieux <slemieux.tyco@gmail.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: OHCI: use module_platform_driver macro
Message-ID: <20161129140343.GB3605@kroah.com>
References: <1479822562-18719-1-git-send-email-csmanjuvijay@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1479822562-18719-1-git-send-email-csmanjuvijay@gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 22, 2016 at 01:49:22PM +0000, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> Use the module_platform_driver macro to do module init/exit.
> This eliminates a lot of boilerplate.This also removes
> checkpatch.pl errors.
> 
> Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Sylvain Lemieux <slemieux.tyco@gmail.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-usb@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/usb/host/ohci-nxp.c | 38 ++++++++++++++------------------------
>  1 file changed, 14 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> index b7d4756..9908647 100644
> --- a/drivers/usb/host/ohci-nxp.c
> +++ b/drivers/usb/host/ohci-nxp.c
> @@ -56,8 +56,6 @@ static struct hc_driver __read_mostly ohci_nxp_hc_driver;
>  
>  static struct i2c_client *isp1301_i2c_client;
>  
> -extern int usb_disabled(void);
> -
>  static struct clk *usb_host_clk;
>  
>  static void isp1301_configure_lpc32xx(void)
> @@ -127,6 +125,7 @@ static inline void isp1301_vbus_off(void)
>  static void ohci_nxp_start_hc(void)
>  {
>  	unsigned long tmp = __raw_readl(USB_OTG_STAT_CONTROL) | HOST_EN;
> +
>  	__raw_writel(tmp, USB_OTG_STAT_CONTROL);
>  	isp1301_vbus_on();
>  }
> @@ -134,6 +133,7 @@ static void ohci_nxp_start_hc(void)
>  static void ohci_nxp_stop_hc(void)
>  {
>  	unsigned long tmp;
> +
>  	isp1301_vbus_off();
>  	tmp = __raw_readl(USB_OTG_STAT_CONTROL) & ~HOST_EN;
>  	__raw_writel(tmp, USB_OTG_STAT_CONTROL);

Why make these last two changes?  They are just coding style "fixups"
that have nothing to do with this patch :(

When you say "also" in a patch description, that's a huge flag that you
should be splitting the patch up into multiple patches.  Please do so
here.

thanks,

greg k-h