From: Alex Thorlton <athorlton@sgi.com>
To: dan.carpenter@oracle.com, mingo@kernel.org, nzimmer@sgi.com,
linux-kernel@vger.kernel.org, travis@sgi.com, tglx@linutronix.de,
hpa@zytor.com, bigeasy@linutronix.de, athorlton@sgi.com,
torvalds@linux-foundation.org, peterz@infradead.org,
sivanich@sgi.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86/apic/uv: Silence a shift wrapping warning
Date: Tue, 29 Nov 2016 15:06:56 -0600 [thread overview]
Message-ID: <20161129210656.GC67776@stormcage.americas.sgi.com> (raw)
In-Reply-To: <tip-c4597fd756836a5fb7900f2091797ab564390ad0@git.kernel.org>
On Wed, Nov 23, 2016 at 10:25:48PM -0800, tip-bot for Dan Carpenter wrote:
> Commit-ID: c4597fd756836a5fb7900f2091797ab564390ad0
> Gitweb: http://git.kernel.org/tip/c4597fd756836a5fb7900f2091797ab564390ad0
> Author: Dan Carpenter <dan.carpenter@oracle.com>
> AuthorDate: Thu, 24 Nov 2016 01:19:08 +0300
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Thu, 24 Nov 2016 06:01:05 +0100
>
> x86/apic/uv: Silence a shift wrapping warning
>
> 'm_io' is stored in 6 bits so it's a number in the 0-63 range. Static
> analysis tools complain that 1 << 63 will wrap so I have changed it to
> 1ULL << m_io.
>
> This code is over three years old so presumably the bug doesn't happen
> very frequently in real life or someone would have complained by now.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Alex Thorlton <athorlton@sgi.com>
Acked-by: Alex Thorlton <athorlton@sgi.com>
- Alex
prev parent reply other threads:[~2016-11-29 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 22:19 [patch] x86/apic/uv: silence " Dan Carpenter
2016-11-24 6:25 ` [tip:x86/urgent] x86/apic/uv: Silence " tip-bot for Dan Carpenter
2016-11-29 21:06 ` Alex Thorlton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129210656.GC67776@stormcage.americas.sgi.com \
--to=athorlton@sgi.com \
--cc=bigeasy@linutronix.de \
--cc=dan.carpenter@oracle.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nzimmer@sgi.com \
--cc=peterz@infradead.org \
--cc=sivanich@sgi.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome