From: "Amit Kumar Kushwaha" <kushwaha.a@samsung.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"akkushwaha9896@gmail.com" <akkushwaha9896@gmail.com>
Subject: [PATCH] usb: host: replace symbolic permission with octal
Date: Wed, 30 Nov 2016 13:49:02 +0000 [thread overview]
Message-ID: <20161130134902epcms5p7d33e26394dec3f931fc623bdb023482d@epcms5p7> (raw)
In-Reply-To: <CGME20161130134902epcms5p7d33e26394dec3f931fc623bdb023482d@epcms5p7>
[-- Attachment #1: Type: text/plain, Size: 991 bytes --]
This patch handles warning message for preferring octal
permissions over Symbolic permission for module parameter
Signed-off-by: Amit Kushwaha <kushwaha.a@samsung.com>
---
drivers/usb/host/xhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 1a4ca02..a953d47 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -40,11 +40,11 @@
/* Some 0.95 hardware can't handle the chain bit on a Link TRB being cleared */
static int link_quirk;
-module_param(link_quirk, int, S_IRUGO | S_IWUSR);
+module_param(link_quirk, int, 0644);
MODULE_PARM_DESC(link_quirk, "Don't clear the chain bit on a link TRB");
static unsigned int quirks;
-module_param(quirks, uint, S_IRUGO);
+module_param(quirks, uint, 0444);
MODULE_PARM_DESC(quirks, "Bit flags for quirks to be enabled as default");
/* TODO: copied from ehci-hcd.c - can this be refactored? */
--
2.10.2.windows.1
next parent reply other threads:[~2016-11-30 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161130134902epcms5p7d33e26394dec3f931fc623bdb023482d@epcms5p7>
2016-11-30 13:49 ` Amit Kumar Kushwaha [this message]
2016-11-30 13:56 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130134902epcms5p7d33e26394dec3f931fc623bdb023482d@epcms5p7 \
--to=kushwaha.a@samsung.com \
--cc=akkushwaha9896@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®