From: Bjorn Helgaas <helgaas@kernel.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
David Daney <david.daney@cavium.com>
Subject: Re: Ping: [PATCH] PCI/ASPM: Don't retrain link if ASPM not possible.
Date: Wed, 30 Nov 2016 12:01:43 -0600 [thread overview]
Message-ID: <20161130180143.GC13411@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <583F082F.1010701@caviumnetworks.com>
Hi David,
On Wed, Nov 30, 2016 at 09:11:11AM -0800, David Daney wrote:
> On 11/17/2016 02:25 PM, David Daney wrote:
> >From: David Daney <david.daney@cavium.com>
> >
> >Some (defective) PCIe devices are not able to reliably do link
> >retraining.
> >
> >Check to see if ASPM is possible between link partners before
> >configuring common clocking, and doing the resulting link retraining.
> >If ASPM is not possible, there is no reason to risk losing access to a
> >device due to an unnecessary link retraining.
> >
>
> Hi Bjorn,
>
> It has been a couple of weeks since I originally sent this, and I
> wanted to know if you have had a chance to look at it. If possible,
> it would be nice to consider for the approaching merge window.
Yes, definitely. I haven't had a chance yet, but I hope to. Right
now my top priority is getting the arm64 ECAM quirks in for v4.10.
Once that's settled I'll come back and pick up some of these fixes.
Bjorn
next prev parent reply other threads:[~2016-11-30 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 22:25 David Daney
2016-11-30 17:11 ` Ping: " David Daney
2016-11-30 18:01 ` Bjorn Helgaas [this message]
2016-12-08 20:47 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130180143.GC13411@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=david.daney@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luto@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®