From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758109AbcLAOQe (ORCPT ); Thu, 1 Dec 2016 09:16:34 -0500 Received: from smtprelay0020.hostedemail.com ([216.40.44.20]:53455 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750738AbcLAOQc (ORCPT ); Thu, 1 Dec 2016 09:16:32 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1434:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2897:3138:3139:3140:3141:3142:3354:3622:3868:3873:5007:6120:6261:6742:7875:7901:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12740:12760:13439:14181:14659:14721:21080:21451:30003:30029:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: coil55_72e7b9d10f44f X-Filterd-Recvd-Size: 3937 Date: Thu, 1 Dec 2016 09:16:28 -0500 From: Steven Rostedt To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, Alexander Viro , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Ingo Molnar , Jan Kara , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH v2 3/6] dax: add tracepoint infrastructure, PMD tracing Message-ID: <20161201091628.7057580f@gandalf.local.home> In-Reply-To: <1480549533-29038-4-git-send-email-ross.zwisler@linux.intel.com> References: <1480549533-29038-1-git-send-email-ross.zwisler@linux.intel.com> <1480549533-29038-4-git-send-email-ross.zwisler@linux.intel.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Nov 2016 16:45:30 -0700 Ross Zwisler wrote: > --- /dev/null > +++ b/include/trace/events/fs_dax.h > @@ -0,0 +1,68 @@ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM fs_dax > + > +#if !defined(_TRACE_FS_DAX_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_FS_DAX_H > + > +#include > + > +DECLARE_EVENT_CLASS(dax_pmd_fault_class, > + TP_PROTO(struct inode *inode, struct vm_area_struct *vma, > + unsigned long address, unsigned int flags, pgoff_t pgoff, > + pgoff_t max_pgoff, int result), > + TP_ARGS(inode, vma, address, flags, pgoff, max_pgoff, result), > + TP_STRUCT__entry( > + __field(dev_t, dev) > + __field(unsigned long, ino) > + __field(unsigned long, vm_start) > + __field(unsigned long, vm_end) > + __field(unsigned long, vm_flags) > + __field(unsigned long, address) > + __field(unsigned int, flags) > + __field(pgoff_t, pgoff) > + __field(pgoff_t, max_pgoff) > + __field(int, result) For better compaction, I would put flags and result together, as they are both ints. Otherwise, you'll probably have 4 empty bytes after flags. -- Steve > + ), > + TP_fast_assign( > + __entry->dev = inode->i_sb->s_dev; > + __entry->ino = inode->i_ino; > + __entry->vm_start = vma->vm_start; > + __entry->vm_end = vma->vm_end; > + __entry->vm_flags = vma->vm_flags; > + __entry->address = address; > + __entry->flags = flags; > + __entry->pgoff = pgoff; > + __entry->max_pgoff = max_pgoff; > + __entry->result = result; > + ), > + TP_printk("dev %d:%d ino %#lx %s %s address %#lx vm_start " > + "%#lx vm_end %#lx pgoff %#lx max_pgoff %#lx %s", > + MAJOR(__entry->dev), > + MINOR(__entry->dev), > + __entry->ino, > + __entry->vm_flags & VM_SHARED ? "shared" : "private", > + __print_flags(__entry->flags, "|", FAULT_FLAG_TRACE), > + __entry->address, > + __entry->vm_start, > + __entry->vm_end, > + __entry->pgoff, > + __entry->max_pgoff, > + __print_flags(__entry->result, "|", VM_FAULT_RESULT_TRACE) > + ) > +) > + > +#define DEFINE_PMD_FAULT_EVENT(name) \ > +DEFINE_EVENT(dax_pmd_fault_class, name, \ > + TP_PROTO(struct inode *inode, struct vm_area_struct *vma, \ > + unsigned long address, unsigned int flags, pgoff_t pgoff, \ > + pgoff_t max_pgoff, int result), \ > + TP_ARGS(inode, vma, address, flags, pgoff, max_pgoff, result)) > + > +DEFINE_PMD_FAULT_EVENT(dax_pmd_fault); > +DEFINE_PMD_FAULT_EVENT(dax_pmd_fault_done); > + > + > +#endif /* _TRACE_FS_DAX_H */ > + > +/* This part must be outside protection */ > +#include