From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933108AbcLAOMh (ORCPT ); Thu, 1 Dec 2016 09:12:37 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:57422 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758098AbcLAOM0 (ORCPT ); Thu, 1 Dec 2016 09:12:26 -0500 Date: Thu, 1 Dec 2016 15:11:39 +0100 From: Sebastian Andrzej Siewior To: Yang Shi Cc: linux@armlinux.org.uk, rostedt@goodmis.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rt-users@vger.kernel.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH] arm: kprobe: replace patch_lock to raw lock Message-ID: <20161201141138.css266nzcutzfapw@linutronix.de> References: <1478823475-15087-1-git-send-email-yang.shi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1478823475-15087-1-git-send-email-yang.shi@linaro.org> User-Agent: NeoMutt/20161104 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-11-10 16:17:55 [-0800], Yang Shi wrote: > > Since patch_text_stop_machine() is called in stop_machine() which disables IRQ, > sleepable lock should be not used in this atomic context, so replace patch_lock > to raw lock. I am taking this one. Thank you. We have jump_labels() deactivated on ARM because stop_machine() may cause latencies at runtime. kprobe and kgdb is used by the user on purpose (and not because he changed some sched setting) I think we are fine. I am going to document this. > Signed-off-by: Yang Shi Sebastian