From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759501AbcLAOVT (ORCPT ); Thu, 1 Dec 2016 09:21:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48208 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756009AbcLAOVS (ORCPT ); Thu, 1 Dec 2016 09:21:18 -0500 Date: Thu, 1 Dec 2016 15:21:10 +0100 From: Benjamin Tissoires To: Rasmus Villemoes Cc: Srinivas Pandruvada , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: intel_ish-hid: use %pUL for uuid formatting Message-ID: <20161201142110.GB1280@mail.corp.redhat.com> References: <1480546127-3539-1-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1480546127-3539-1-git-send-email-linux@rasmusvillemoes.dk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 01 Dec 2016 14:21:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 30 2016 or thereabouts, Rasmus Villemoes wrote: > We have the %pU printf extension for doing exactly this. Saves some > .text, and is likely also a little faster. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Benjamin Tissoires > --- > drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c > index 256521509d20..f4cbc744e657 100644 > --- a/drivers/hid/intel-ish-hid/ishtp/bus.c > +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c > @@ -585,14 +585,7 @@ int ishtp_bus_new_client(struct ishtp_device *dev) > */ > i = dev->fw_client_presentation_num - 1; > device_uuid = dev->fw_clients[i].props.protocol_name; > - dev_name = kasprintf(GFP_KERNEL, > - "{%02X%02X%02X%02X-%02X%02X-%02X%02X-%02X%02X-%02X%02X%02X%02X%02X%02X}", > - device_uuid.b[3], device_uuid.b[2], device_uuid.b[1], > - device_uuid.b[0], device_uuid.b[5], device_uuid.b[4], > - device_uuid.b[7], device_uuid.b[6], device_uuid.b[8], > - device_uuid.b[9], device_uuid.b[10], device_uuid.b[11], > - device_uuid.b[12], device_uuid.b[13], device_uuid.b[14], > - device_uuid.b[15]); > + dev_name = kasprintf(GFP_KERNEL, "{%pUL}", device_uuid.b); > if (!dev_name) > return -ENOMEM; > > -- > 2.1.4 >