From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173AbcLBQ5u (ORCPT ); Fri, 2 Dec 2016 11:57:50 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:36522 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438AbcLBQ4Z (ORCPT ); Fri, 2 Dec 2016 11:56:25 -0500 Date: Fri, 02 Dec 2016 11:56:19 -0500 (EST) Message-Id: <20161202.115619.1098706795726222374.davem@davemloft.net> To: arnd@arndb.de Cc: saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, kamalh@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net/mlx5e: skip loopback selftest with !CONFIG_INET From: David Miller In-Reply-To: <20161130210552.1756085-1-arnd@arndb.de> References: <20161130210552.1756085-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 02 Dec 2016 07:56:59 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Wed, 30 Nov 2016 22:05:39 +0100 > When CONFIG_INET is disabled, the new selftest results in a link > error: > > drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.o: In function `mlx5e_test_loopback': > en_selftest.c:(.text.mlx5e_test_loopback+0x2ec): undefined reference to `ip_send_check' > en_selftest.c:(.text.mlx5e_test_loopback+0x34c): undefined reference to `udp4_hwcsum' > > This hides the specific test in that configuration. > > Fixes: 0952da791c97 ("net/mlx5e: Add support for loopback selftest") > Signed-off-by: Arnd Bergmann Applied, thanks Arnd.