From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752600AbcLDEju (ORCPT ); Sat, 3 Dec 2016 23:39:50 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:42222 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbcLDEjs (ORCPT ); Sat, 3 Dec 2016 23:39:48 -0500 Date: Sat, 03 Dec 2016 23:39:45 -0500 (EST) Message-Id: <20161203.233945.1757084444220812603.davem@davemloft.net> To: arnd@arndb.de Cc: felix.manlunas@caviumnetworks.com, tglx@linutronix.de, david.daney@cavium.com, satananda.burla@caviumnetworks.com, rvatsavayi@caviumnetworks.com, nicolas.pitre@linaro.org, sgoutham@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select' From: David Miller In-Reply-To: <20161202230451.1639318-1-arnd@arndb.de> References: <20161202230451.1639318-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 03 Dec 2016 19:40:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Sat, 3 Dec 2016 00:04:32 +0100 > ptp now depends on the optional POSIX_TIMERS setting and fails to build > if we select it without that: > > warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet direct dependencies (NET && POSIX_TIMERS) > warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet direct dependencies (NET && POSIX_TIMERS) > ERROR: "posix_clock_unregister" [drivers/ptp/ptp.ko] undefined! > ERROR: "posix_clock_register" [drivers/ptp/ptp.ko] undefined! > ERROR: "pps_unregister_source" [drivers/ptp/ptp.ko] undefined! > ERROR: "pps_event" [drivers/ptp/ptp.ko] undefined! > ERROR: "pps_register_source" [drivers/ptp/ptp.ko] undefined! > > It seems that two patches have collided here, the build failure > is a result of the combination. Changing the new option to 'imply' > as well fixes it. > > Fixes: 111fc64a237f ("liquidio CN23XX: VF registration") > Fixes: d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") > Signed-off-by: Arnd Bergmann Like the kbuild robot, when I apply this it complains about 'imply' being an unknown option. I guess it worked for you because support for 'imply' exists in the -next tree and gets pulled in from somewhere else. In any event, as-is I cannot apply this.