From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: tpmdd-devel@lists.sourceforge.net,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd
Date: Sat, 3 Dec 2016 18:15:57 +0200 [thread overview]
Message-ID: <20161203161557.ddqkt46sol55iode@intel.com> (raw)
In-Reply-To: <20161203153236.jmulnrlvoitvjnhq@intel.com>
On Sat, Dec 03, 2016 at 05:32:36PM +0200, Jarkko Sakkinen wrote:
> On Wed, Nov 23, 2016 at 12:04:11PM +0200, Tomas Winkler wrote:
> > Functions tpm_transmit and transmit_cmd are referenced
> > from other functions kdoc hence deserve documentation.
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>
> Do you mind if I change TPM_DIGEST_SIZE to SHA1_DIGEST_SIZE?
>
> I'm looking to drop TPM_DIGEST_SIZE eventually.
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
... in the sense that the changes do not break the compilation and do
not produce sparse or cocciheck errors. I guess that should be enough
for documentation changes.
/Jarkko
next prev parent reply other threads:[~2016-12-03 16:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 10:04 [PATCH v2 0/4] tpm: kdoc cleanup Tomas Winkler
2016-11-23 10:04 ` [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd Tomas Winkler
2016-12-03 15:32 ` Jarkko Sakkinen
2016-12-03 16:15 ` Jarkko Sakkinen [this message]
2016-12-06 9:16 ` [tpmdd-devel] " Nayna
2016-12-06 12:11 ` Winkler, Tomas
2016-11-23 10:04 ` [PATCH v2 2/4] tpm/tpm2-chip: fix kdoc errors Tomas Winkler
2016-12-03 15:34 ` Jarkko Sakkinen
2016-12-03 16:16 ` Jarkko Sakkinen
2016-11-23 10:04 ` [PATCH v2 3/4] tmp: use pdev for parent device in tpm_chip_alloc Tomas Winkler
2016-12-03 15:35 ` Jarkko Sakkinen
2016-12-03 16:16 ` Jarkko Sakkinen
2016-11-23 10:04 ` [PATCH v2 4/4] tpm/vtpm: fix kdoc warnings Tomas Winkler
2016-12-03 15:36 ` Jarkko Sakkinen
2016-12-03 16:17 ` Jarkko Sakkinen
2016-11-23 15:59 ` [PATCH v2 0/4] tpm: kdoc cleanup Jarkko Sakkinen
2016-11-24 13:19 ` Jarkko Sakkinen
2016-12-03 16:19 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161203161557.ddqkt46sol55iode@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tomas.winkler@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome