From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751083AbcLDKHj (ORCPT ); Sun, 4 Dec 2016 05:07:39 -0500 Received: from mail.skyhub.de ([78.46.96.112]:50174 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbcLDKHi (ORCPT ); Sun, 4 Dec 2016 05:07:38 -0500 Date: Sun, 4 Dec 2016 11:07:34 +0100 From: Borislav Petkov To: Pan Bian Cc: Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian Subject: Re: [PATCH 1/1] edac: fix improper return value Message-ID: <20161204100734.glm3eutpsw3h22fm@pd.tnic> References: <1480831638-5361-1-git-send-email-bianpan201604@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1480831638-5361-1-git-send-email-bianpan201604@163.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 04, 2016 at 02:07:18PM +0800, Pan Bian wrote: > From: Pan Bian > > When the call to zalloc_cpumask_var() fails, returning "false" seems > improper. The real value of macro "false" is 0, and 0 means no error. > This patch fixes the bug, returning "-ENOMEM". > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071 That bugzilla entry wasn't really needed. > Signed-off-by: Pan Bian > --- > drivers/edac/amd64_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.