From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbcLEKHK (ORCPT ); Mon, 5 Dec 2016 05:07:10 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:45303 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbcLEKGc (ORCPT ); Mon, 5 Dec 2016 05:06:32 -0500 Date: Mon, 5 Dec 2016 11:06:30 +0100 From: Alexandre Belloni To: Amelie Delaunay Cc: a.zummo@towertech.it, robh+dt@kernel.org, mark.rutland@arm.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linux@armlinux.org.uk, rtc-linux@googlegroups.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gabriel.fernandez@st.com Subject: Re: [PATCH 2/8] dt-bindings: document the STM32 RTC bindings Message-ID: <20161205100630.n3gldznf524pucjm@piout.net> References: <1480687801-19525-2-git-send-email-amelie.delaunay@st.com> <1480687801-19525-4-git-send-email-amelie.delaunay@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480687801-19525-4-git-send-email-amelie.delaunay@st.com> User-Agent: NeoMutt/20161104 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02/12/2016 at 15:09:55 +0100, Amelie Delaunay wrote : > This patch adds documentation of device tree bindings for the STM32 RTC. > > Signed-off-by: Amelie Delaunay > --- > .../devicetree/bindings/rtc/st,stm32-rtc.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt > > diff --git a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt > new file mode 100644 > index 0000000..4578838 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt > @@ -0,0 +1,31 @@ > +STM32 Real Time Clock > + > +Required properties: > +- compatible: "st,stm32-rtc". > +- reg: address range of rtc register set. > +- clocks: reference to the clock entry ck_rtc. > +- clock-names: name of the clock used. Should be "ck_rtc". Is this name really useful? > +- interrupt-parent: phandle for the interrupt controller. > +- interrupts: rtc alarm interrupt. > +- interrupt-names: rtc alarm interrupt name, should be "alarm". Same comment, is this name really useful? -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com