From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Lukas Wunner <lukas@wunner.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Silvio Fricke <silvio.fricke@gmail.com>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Inki Dae <inki.dae@samsung.com>, Joerg Roedel <joro@8bytes.org>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Mark Brown <broonie@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Tomasz Figa <tomasz.figa@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Alan Stern <stern@rowland.harvard.edu>,
Hanjun Guo <guohanjun@huawei.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] Documentation/core-api/device_link: Add initial documentation
Date: Mon, 5 Dec 2016 11:36:49 -0200 [thread overview]
Message-ID: <20161205113627.6eff8aa8@vento.lan> (raw)
In-Reply-To: <20161205060507.6bd6e944@lwn.net>
Em Mon, 5 Dec 2016 06:05:07 -0700
Jonathan Corbet <corbet@lwn.net> escreveu:
> On Mon, 5 Dec 2016 10:07:39 -0200
> Mauro Carvalho Chehab <mchehab@osg.samsung.com> wrote:
>
> > > +Usage
> > > +=====
> >
> > You should be using, instead:
> >
> > Usage
> > -----
> >
> > (and the same '-' symbol for all sections of this chapter)
> >
> > The way you did, in thesis, ReST should be putting all tags at the
> > same level as the first one, as they're all using '='.
>
> Actually, he did exactly what the documentation guide says to do.
Ah, OK! I guess I misread that section of the documentation.
> Since
> it only has the markers below the heading, it will still be at a lower
> level than the top heading, which has markers both above and below.
Yes, I noticed that it is on a lower level than the initial one with
markers above and below.
Lukas,
Documentation seems OK, from ReST PoV. Didn't read the documents
and the C code to be sure that they match the implementation.
Reviewed-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
--
Thanks,
Mauro
next prev parent reply other threads:[~2016-12-05 13:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1480849144.git.lukas@wunner.de>
2016-12-05 12:03 ` [PATCH 0/2] Device links documentation Mauro Carvalho Chehab
2016-12-05 14:08 ` Christoph Hellwig
2016-12-05 14:19 ` Mauro Carvalho Chehab
2016-12-05 15:02 ` Lukas Wunner
2016-12-05 13:09 ` Jonathan Corbet
[not found] ` <a1c7a93ee8ef057fb70aa3abeed38daf989444fc.1480849144.git.lukas@wunner.de>
2016-12-05 12:20 ` [PATCH 2/2] driver core: Silence device links sphinx warning Mauro Carvalho Chehab
2016-12-05 12:44 ` Lukas Wunner
2016-12-05 12:57 ` Mauro Carvalho Chehab
2016-12-05 13:59 ` Greg Kroah-Hartman
[not found] ` <f5b568e349aaeb31039a0c4d01fdb05d8b3bdd2a.1480849144.git.lukas@wunner.de>
2016-12-05 12:07 ` [PATCH 1/2] Documentation/core-api/device_link: Add initial documentation Mauro Carvalho Chehab
2016-12-05 13:05 ` Jonathan Corbet
2016-12-05 13:36 ` Mauro Carvalho Chehab [this message]
2016-12-05 21:15 ` Jonathan Corbet
2016-12-06 1:41 ` Luis R. Rodriguez
2016-12-07 11:50 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205113627.6eff8aa8@vento.lan \
--to=mchehab@osg.samsung.com \
--cc=a.hajda@samsung.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=hch@infradead.org \
--cc=inki.dae@samsung.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kgene@kernel.org \
--cc=khilman@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=m.szyprowski@samsung.com \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=silvio.fricke@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=tomasz.figa@gmail.com \
--cc=tomeu.vizoso@collabora.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome