From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbcLEX0Q (ORCPT ); Mon, 5 Dec 2016 18:26:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58936 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbcLEX0O (ORCPT ); Mon, 5 Dec 2016 18:26:14 -0500 Date: Mon, 5 Dec 2016 16:26:13 -0700 From: Alex Williamson To: Kirti Wankhede Cc: , , , , , Subject: Re: [PATCH 1/1] vfio iommu type1: WARN_ON if notifier block is not unregistered Message-ID: <20161205162613.693a7c52@t450s.home> In-Reply-To: <1480972100-846-1-git-send-email-kwankhede@nvidia.com> References: <1480972100-846-1-git-send-email-kwankhede@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 05 Dec 2016 23:26:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Dec 2016 02:38:20 +0530 Kirti Wankhede wrote: > mdev vendor driver should unregister the iommu notifier since the vfio > iommu can persist beyond the attachment of the mdev group. WARN_ON will > show warning if vendor driver doesn't unregister the notifier and is > forced to follow the implementations steps. > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia > Change-Id: I75fd0a40e582a144fe7a037c7140d3513e8ff030 > --- > drivers/vfio/vfio_iommu_type1.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 023fba7b8d5a..37871ee0c0c5 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -1361,6 +1361,8 @@ static void vfio_sanity_check_pfn_list(struct vfio_iommu *iommu) > if (WARN_ON(!RB_EMPTY_ROOT(&dma->pfn_list))) > break; > } > + /* mdev venfor driver must unregister notifier */ s/venfor/vendor/ > + WARN_ON(iommu->notifier.head); > } > > static void vfio_iommu_type1_detach_group(void *iommu_data, Applied for v4.10 with the above typo fix. Thanks, Alex