From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751845AbcLEUZM (ORCPT ); Mon, 5 Dec 2016 15:25:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44870 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbcLEUZL (ORCPT ); Mon, 5 Dec 2016 15:25:11 -0500 Date: Mon, 5 Dec 2016 14:24:57 -0600 From: Josh Poimboeuf To: Jiri Slaby Cc: mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] objtool: fix bytes check of lea's rex_prefix Message-ID: <20161205202457.4coobxhoosnzobo5@treble> References: <20161205105551.25917-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161205105551.25917-1-jslaby@suse.cz> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 05 Dec 2016 20:24:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 05, 2016 at 11:55:51AM +0100, Jiri Slaby wrote: > For the "lea %(rsp), %rbp" case, we check if there is a rex_prefix. But > we check "bytes" which is insn_byte_t[4] in rex_prefix (insn_field > structure). Therefore, the check is always true. > > Instead, check nbytes which is the right one. > > Signed-off-by: Jiri Slaby > Cc: Josh Poimboeuf Acked-by: Josh Poimboeuf