From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753055AbcLFOcu (ORCPT ); Tue, 6 Dec 2016 09:32:50 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:40630 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbcLFOcs (ORCPT ); Tue, 6 Dec 2016 09:32:48 -0500 Date: Tue, 06 Dec 2016 09:32:46 -0500 (EST) Message-Id: <20161206.093246.1063828677061160197.davem@davemloft.net> To: jiri@resnulli.us Cc: cxdx2006@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, feng.deng@cortina-access.com Subject: Re: [PATCH]net:switchdev:add judgement and proper return vlaue to make switchdev_port_vlan_fill() more robust From: David Miller In-Reply-To: <20161206123225.GK1984@nanopsycho> References: <20161206123225.GK1984@nanopsycho> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Dec 2016 05:33:25 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Pirko Date: Tue, 6 Dec 2016 13:32:25 +0100 > Tue, Dec 06, 2016 at 05:46:36AM CET, cxdx2006@gmail.com wrote: >>From: Feng Deng >> >>1.add judgement to make sure switchdev_port_vlan_fill() could >> return right, even when switchdev_port_vlan_dump_put() failed , >> which will make switchdev_port_vlan_fill() more robust >>2.add proper return vlaue at the end of the switchdev_port_vlan_fill() >> >>Signed-off-by: Feng Deng > > Please don't send patches like this. You are wasting everyone's time. +1