From: David Miller <davem@davemloft.net>
To: mikko.rapeli@iki.fi
Cc: jonas.gorski@gmail.com, linux-kernel@vger.kernel.org,
zhangshengju@cmss.chinamobile.com
Subject: Re: [PATCH] uapi glibc compat: fix outer guard of net device flags enum
Date: Tue, 06 Dec 2016 10:44:00 -0500 (EST) [thread overview]
Message-ID: <20161206.104400.2131603846152593015.davem@davemloft.net> (raw)
In-Reply-To: <20161205173401.GU8342@lakka.kapsi.fi>
From: Mikko Rapeli <mikko.rapeli@iki.fi>
Date: Mon, 5 Dec 2016 19:34:02 +0200
> On Sat, Dec 03, 2016 at 05:31:45PM +0100, Jonas Gorski wrote:
>> Fix a wrong condition preventing the higher net device flags
>> IFF_LOWER_UP etc to be defined if net/if.h is included before
>> linux/if.h.
>>
>> The comment makes it clear the intention was to allow partial
>> definition with either parts.
>>
>> This fixes compilation of userspace programs trying to use
>> IFF_LOWER_UP, IFF_DORMANT or IFF_ECHO.
>>
>> Fixes: 4a91cb61bb99 ("uapi glibc compat: fix compile errors when glibc net/if.h included before linux/if.h")
>> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
>
> Reviewed-by: Mikko Rapeli <mikko.rapeli@iki.fi>
>
> Yep, sorry about the logic error. Thanks for the fix!
Applied.
Jonas, please properly put netdev@vger.kernel.org on the CC: for networking
patches in the future.
Thank you.
prev parent reply other threads:[~2016-12-06 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 16:31 Jonas Gorski
2016-12-05 17:34 ` Mikko Rapeli
2016-12-06 15:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206.104400.2131603846152593015.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikko.rapeli@iki.fi \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®