From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753698AbcLFQjF (ORCPT ); Tue, 6 Dec 2016 11:39:05 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:43046 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752151AbcLFQjD (ORCPT ); Tue, 6 Dec 2016 11:39:03 -0500 Date: Tue, 06 Dec 2016 11:39:01 -0500 (EST) Message-Id: <20161206.113901.1729006808840379027.davem@davemloft.net> To: luto@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, mst@redhat.com, jasowang@redhat.com, labbott@redhat.com Subject: Re: [PATCH] virtio-net: Fix DMA-from-the-stack in virtnet_set_mac_address() From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Dec 2016 07:39:41 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Lutomirski Date: Mon, 5 Dec 2016 18:10:58 -0800 > With CONFIG_VMAP_STACK=y, virtnet_set_mac_address() can be passed a > pointer to the stack and it will OOPS. Copy the address to the heap > to prevent the crash. > > Cc: Michael S. Tsirkin > Cc: Jason Wang > Cc: Laura Abbott > Reported-by: zbyszek@in.waw.pl > Signed-off-by: Andy Lutomirski Applied, thanks.