From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbcLFIHf (ORCPT ); Tue, 6 Dec 2016 03:07:35 -0500 Received: from mail-wj0-f193.google.com ([209.85.210.193]:36402 "EHLO mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605AbcLFIG6 (ORCPT ); Tue, 6 Dec 2016 03:06:58 -0500 Date: Tue, 6 Dec 2016 09:06:55 +0100 From: Jiri Pirko To: Feng Deng Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, feng.deng@cortina-access.com Subject: Re: [PATCH]net:witchdev:release the lock before function return to avoid dead lock Message-ID: <20161206080655.GC1984@nanopsycho> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, Dec 06, 2016 at 03:58:29AM CET, cxdx2006@gmail.com wrote: >>From : Feng Deng > >In switchdev_deferred_dequeue(),only get the lock at the beginning, >but forgot to release before return, >we must release the lock to avoid dead lock Feng, your patches are corrupted. Please use "git send-email" Also, when you send a fit for -net tree, you have to pass byt the "Fixes" tag. Please see the git log for details. Thanks! > >Signed-off-by: Feng Deng >--- > net/switchdev/switchdev.c | 1 + > 1 file changed, 1 insertion(+) > mode change 100644 => 100755 net/switchdev/switchdev.c > >diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c >index 3b95fe9..c0a1ad4 >--- a/net/switchdev/switchdev.c >+++ b/net/switchdev/switchdev.c >@@ -120,6 +120,7 @@ static struct switchdev_deferred_item >*switchdev_deferred_dequeue(void) > dfitem = list_first_entry(&deferred, > struct switchdev_deferred_item, list); > list_del(&dfitem->list); >+ spin_unlock_bh(&deferred_lock); > unlock: > spin_unlock_bh(&deferred_lock); > return dfitem; >-- >1.8.3.1