From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752879AbcLFWqW (ORCPT ); Tue, 6 Dec 2016 17:46:22 -0500 Received: from ozlabs.org ([103.22.144.67]:52951 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752186AbcLFWqT (ORCPT ); Tue, 6 Dec 2016 17:46:19 -0500 Date: Wed, 7 Dec 2016 09:46:17 +1100 From: Stephen Rothwell To: Peter Rosin Cc: "linux-kernel@vger.kernel.org" , Linus Walleij , Andrew Lunn , linux-next@vger.kernel.org Subject: Re: linux-next: build failure after merge of the pinctrl tree Message-ID: <20161207094405.05e4e5c2@canb.auug.org.au> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Tue, 6 Dec 2016 23:27:48 +0100 Peter Rosin wrote: > > The bug you are referring to is in the gpio tree, not pinctrl. > That had me confused for a while, and is the reason I'm writing > this. Maybe the next person need not be confused... Part of the gpio tree has been merged into the pinctrl tree (see commit 70afa835d2d7 ("Merge branch 'thread-irq-simpler' of /home/linus/linux-gpio into devel")), but when I merge the gpio tree later in my process, I do not get this error. > But when I'm writing on this topic anyway, I'll add some more > info, in case anyone cares. > > I think fix for this bug is to use gc->irq_chained_parent instead > of gc->irq_parent, at least that changed as part of the indicated > commit. Completely untested... > > The fix for the bug in the pinctrl tree is to add a missing > > as posted by Andrew Lunn in [1] (with a slightly broken commit > message; two counts of s/chip-/client-/, an extra line after > the sob and I guess the subject is no longer true). > > Cheers, > Peter > > [1] http://marc.info/?l=linux-gpio&m=148088890030876&w=2 Thanks for the info ... this still needs fixing in the pinctrl tree. P.S. Peter, your email had a bad header line: Reply-To: 20161207083102.093fdf96@canb.auug.org.au that should probably have been In-Reply-To ... -- Cheers, Stephen Rothwell