From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933758AbcLHAeS (ORCPT ); Wed, 7 Dec 2016 19:34:18 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:60334 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932441AbcLHAeR (ORCPT ); Wed, 7 Dec 2016 19:34:17 -0500 Date: Thu, 8 Dec 2016 01:34:11 +0100 From: Alexandre Belloni To: Emil Bartczak Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Provides bug fixes for rtc-mcp795.c Message-ID: <20161208003411.4eqm4w4c3nuepegy@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161104 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/12/2016 at 00:27:36 +0100, Emil Bartczak wrote : > This patchset provides 4 bug fixes (patch 1, 2, 3, 4), one > improvement (patch 5) and whitespace, indention errors fixes > (patch 6) in the file driver/rtc/rtc-mcp795.c. > Please review the changes and consider to apply them to the > main kernel tree. > > Changes from v1: > - Introduced SoB to all patches. > - Patch which switches to bcd2bin/bin2bcd became as first now, > it also solved the shift problem presented in the previous patch 1. > - Added restoring EXTOSC bit to its previous value. > - All whitespace and indention fixes moved to the new patch 6. > - Added new patch which replaces all bitmask values with the > BIT(x) macro. > > Emil Bartczak (6): > rtc: mcp795: use bcd2bin/bin2bcd. > rtc: mcp795: fix bitmask value for leap year (LP). > rtc: mcp795: fix time range difference between linux and RTC chip. > rtc: mcp795: fix month write resetting date to 1. > rtc: mcp795: Prefer using the BIT() macro. > rtc: mcp795: Fix whitespace and indentation. > > drivers/rtc/rtc-mcp795.c | 122 ++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 100 insertions(+), 22 deletions(-) > All applied, thanks! -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com