From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
open list <linux-kernel@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>
Subject: Re: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers
Date: Mon, 12 Dec 2016 19:46:15 +0200 [thread overview]
Message-ID: <20161212174615.mhk44plbj5wg4zzs@intel.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B5433B524@hasmsx108.ger.corp.intel.com>
On Mon, Dec 12, 2016 at 03:28:01PM +0000, Winkler, Tomas wrote:
> >
> > I've tested is completley disjoint from the region pointed by the ACPI device
> > tree (SSDT in PTT's case).
> >
> > Here's example device from my x250:
> >
> > Device (TPM)
> > {
> > Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */) // _HID: Hardware ID
> > Name (_STR, Unicode ("TPM 2.0 Device")) // _STR: Description String Name
> > (CRS, ResourceTemplate () { Memory32Fixed (ReadOnly,
> > 0x00000000, // Address Base
> > 0x00001000, // Address Length
> > _Y00)
>
>
> I'm not sure what is that?
>
> > Memory32Fixed (ReadOnly,
> > 0xFED70000, // Address Base
> > 0x00001000, // Address Length
> > )
>
> But 0xFED70000 should point to CCA
When I implemented originally the driver I followed the MS specification
and used the value from TPM2 ACPI table.
The driver ioremaps 00000000CCDFF000, not the address from SSDT.
> Tomas
> Thanks
/Jarkko
next prev parent reply other threads:[~2016-12-12 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 11:49 [PATCH v3 0/3] Locality support for tpm_crb Jarkko Sakkinen
2016-12-07 11:49 ` [PATCH v3 1/3] tpm_crb: map locality registers Jarkko Sakkinen
2016-12-12 14:25 ` [tpmdd-devel] " Winkler, Tomas
2016-12-12 15:20 ` Jarkko Sakkinen
2016-12-12 15:28 ` Winkler, Tomas
2016-12-12 17:46 ` Jarkko Sakkinen [this message]
2016-12-12 15:31 ` Jarkko Sakkinen
2016-12-12 15:32 ` Jarkko Sakkinen
2016-12-12 15:57 ` Winkler, Tomas
2016-12-12 17:53 ` Jarkko Sakkinen
2016-12-12 17:59 ` Jarkko Sakkinen
2016-12-07 11:49 ` [PATCH v3 2/3] tpm_crb: encapsulate crb_wait_for_reg_32 Jarkko Sakkinen
2016-12-07 11:50 ` [PATCH v3 3/3] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212174615.mhk44plbj5wg4zzs@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tomas.winkler@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome