From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751621AbcLLSqM (ORCPT ); Mon, 12 Dec 2016 13:46:12 -0500 Received: from mail-yw0-f196.google.com ([209.85.161.196]:34150 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbcLLSqL (ORCPT ); Mon, 12 Dec 2016 13:46:11 -0500 Date: Mon, 12 Dec 2016 13:46:09 -0500 From: Tejun Heo To: Rob Herring Cc: Vladimir Zapolskiy , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] driver core: flush async calls before testing driver removal Message-ID: <20161212184609.GH13864@htj.duckdns.org> References: <20161210001519.24870-1-vz@mleia.com> <20161210073245.GA19610@kroah.com> <4c1eb9e4-3e49-660a-e3c2-d048d3189a26@mleia.com> <20161210130404.GB8145@kroah.com> <20161212175039.GC13864@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Dec 12, 2016 at 12:33:36PM -0600, Rob Herring wrote: > Maybe I'm confused, but don't you need this for all drivers? You need > sync the async SCSI scanning to the driver remove regardless of async > probe. The driver core synchronization is only for synchronizing the > remove with probe AIUI. Heh, I'm not quite following what you mean. Can you please elaborate? Also, on the second thought, it probably would be better to flush async calls before unbind. It's fragile to require indivdiual drivers to do that and I can't think of benefits of doing so. It's not like the unbind / unload paths are hot in any way. Thanks. -- tejun