From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933292AbcLMO0M (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Dec 2016 09:26:12 -0500
Received: from mx2.suse.de ([195.135.220.15]:53488 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932490AbcLMO0K (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Dec 2016 09:26:10 -0500
Date: Tue, 13 Dec 2016 15:26:02 +0100
From: David Sterba <dsterba@suse.cz>
To: Petr Mladek <pmladek@suse.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Chris Mason <clm@fb.com>,
        Josef Bacik <jbacik@fb.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Joe Perches <joe@perches.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jason Wessel <jason.wessel@windriver.com>
Subject: Re: [PATCH v2 3/4] printk/btrfs: Handle more message headers
Message-ID: <20161213142602.GB12522@suse.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Petr Mladek <pmladek@suse.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>, Chris Mason <clm@fb.com>,
        Josef Bacik <jbacik@fb.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Joe Perches <joe@perches.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jason Wessel <jason.wessel@windriver.com>
References: <1478695291-12169-1-git-send-email-pmladek@suse.com>
 <1478695291-12169-4-git-send-email-pmladek@suse.com>
 <CAMuHMdUer4VkNmAgp7kLX1KukVFKYzNvi69EKuY-CuAqh9u-ww@mail.gmail.com>
 <20161213135246.GQ3506@pathway.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20161213135246.GQ3506@pathway.suse.cz>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 13, 2016 at 02:52:47PM +0100, Petr Mladek wrote:
> Here is the proposed fix for the warning:
> 
> 
> From 5b5a8f7ff4f2d5c33316e600a29d45314ac47a16 Mon Sep 17 00:00:00 2001
> From: Petr Mladek <pmladek@suse.com>
> Date: Tue, 13 Dec 2016 13:12:56 +0100
> Subject: [PATCH] btrfs: Better handle btrfs_printk() defaults
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The commit 262c5e86fec7cfd ("printk/btrfs: handle more message headers")
> triggers:
> 
>     warning: ‘ratelimit’ may be used uninitialized in this function
> 
> with gcc (4.1.2) and probably many other versions. The code actually
> is correct but a bit twisted. Let's make it more straightforward
> and set the default values at the beginning.
> 
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Petr Mladek <pmladek@suse.com>

Acked-by: David Sterba <dsterba@suse.com>