mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jonas Bonn <jonas@southpole.se>,
	openrisc@lists.librecores.org,
	Wu Fengguang <fengguang.wu@intel.com>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [OpenRISC] [PATCH] openrisc: Add _text symbol to fix ksym build error
Date: Wed, 14 Dec 2016 22:12:30 +0900	[thread overview]
Message-ID: <20161214131230.GF2650@lianli.shorne-pla.net> (raw)
In-Reply-To: <CAMuHMdX8fKxmWB60Wx-oi5bYu79X1brOHfDH-uN9nryidvk55w@mail.gmail.com>

Hi Geert,

On Wed, Dec 14, 2016 at 01:58:32PM +0100, Geert Uytterhoeven wrote:
> Hi Stafford,
> 
> On Wed, Dec 14, 2016 at 1:55 PM, Stafford Horne <shorne@gmail.com> wrote:
> > The build report reports:
> >
> >    .tmp_kallsyms1.o: In function `kallsyms_relative_base':
> >>> (.rodata+0x8a18): undefined reference to `_text'
> >
> > This is when using 'make alldefconfig'. Adding this _text symbol to mark
> > the start of the kernel as in other architecture fixes this.
> >
> > Signed-off-by: Stafford Horne <shorne@gmail.com>
> > ---
> >  arch/openrisc/kernel/vmlinux.lds.S | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/openrisc/kernel/vmlinux.lds.S b/arch/openrisc/kernel/vmlinux.lds.S
> > index ef31fc2..58eaca0 100644
> > --- a/arch/openrisc/kernel/vmlinux.lds.S
> > +++ b/arch/openrisc/kernel/vmlinux.lds.S
> > @@ -44,6 +44,8 @@ SECTIONS
> >          /* Read-only sections, merged into text segment: */
> >          . = LOAD_BASE ;
> >
> > +       _text = .;
> > +
> >         /* _s_kernel_ro must be page aligned */
> >         . = ALIGN(PAGE_SIZE);
> >         _s_kernel_ro = .;
> > @@ -66,6 +68,7 @@ SECTIONS
> >          * fixup is definitely necessary
> >          */
> >
> > +       _data = .;
> 
> This change is not mentioned in the patch description.
> Is it required? Does it fix something different?

Good point.

I was just adding what I saw as missing in others. Also what I read in
include/asm-generic/sections.h.  However, when I read a bit closer it
mentions its only optional.

I will remove, it does not fix anything.

-Stafford

> >         _sdata = .;
> >
> >         /* Page alignment required for RO_DATA_SECTION */
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

      reply	other threads:[~2016-12-14 13:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-14 12:55 Stafford Horne
2016-12-14 12:58 ` [OpenRISC] " Geert Uytterhoeven
2016-12-14 13:12   ` Stafford Horne [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161214131230.GF2650@lianli.shorne-pla.net \
    --to=shorne@gmail.com \
    --cc=fengguang.wu@intel.com \
    --cc=geert@linux-m68k.org \
    --cc=jonas@southpole.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=openrisc@lists.librecores.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®