From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756059AbcLNOBC (ORCPT ); Wed, 14 Dec 2016 09:01:02 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:44279 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753821AbcLNOA4 (ORCPT ); Wed, 14 Dec 2016 09:00:56 -0500 X-AuditID: cbfee61b-f796f6d000004092-29-5851508cdbc1 From: Andi Shyti To: Mauro Carvalho Chehab , Sean Young , Rob Herring , Mark Rutland , Richard Purdie , Jacek Anaszewski , Heiner Kallweit Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH v4 3/6] [media] rc-core: add support for IR raw transmitters Date: Wed, 14 Dec 2016 23:00:27 +0900 Message-id: <20161214140030.28537-4-andi.shyti@samsung.com> X-Mailer: git-send-email 2.10.2 In-reply-to: <20161214140030.28537-1-andi.shyti@samsung.com> References: <20161214140030.28537-1-andi.shyti@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsVy+t9jQd2egMAIgwXX5S22H3nGarH4x3Mm i/lHzrFaLHo/g9Wi9+pzRovLu+awWWx9s47RomfDVlaLpdcvMlmsflZh0br3CLvF7l1PWS0W Pv3O4sDrsWbeGkaP60s+MXvsnHWX3WPTqk42jyVvrD229AN5e+b/YPXo27KK0ePzJrkAzig3 m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4Byvp 2yW4ZRyd08hYMFm+4v6bNSwNjM8kuxg5OSQETCS+fTrHCGGLSVy4t56ti5GLQ0hgFqPEpWeH WCGcj4wSOxafYQGpYhPQlGi6/QOsSkRgOpPE1y8HwBLMAnsZJfZ+9AGxhQV8JD7dmMIOYrMI qEqcmbQezOYVsJY403yeDWKdvMTC80eYQGxOARuJPV3PwGwhoJrn22cyT2DkXcDIsIpRIrUg uaA4KT3XKC+1XK84Mbe4NC9dLzk/dxMjOG6eSe9gPLzL/RCjAAejEg9vAjCehFgTy4orcw8x SnAwK4nwTvEFCvGmJFZWpRblxxeV5qQWH2I0BTpsIrOUaHI+MKbzSuINTcxNzI0NLMwtLU2M lMR5G2c/CxcSSE8sSc1OTS1ILYLpY+LglGpgFDzCxsh6UGv2gddGD/Wmxjs/bt5Vc1s5WjAv L7RvSrvFMgZFW1EJRs9fieFs6e8uBV7aOHv/4m3TbBsln1T++yQ1lbP8RukO22PFD7qk+U3L 3r59Z6hxKl+94PqPgikvzvnU184pXfrwk2a7cuLtiBcP32g9LlpYbtA14+KDM/U1T6d/i3ut rMRSnJFoqMVcVJwIAAFz4+OxAgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IR raw transmitter driver type is specified in the enum rc_driver_type as RC_DRIVER_IR_RAW_TX which includes all those devices that transmit raw stream of bit to a receiver. The data are provided by userspace applications, therefore they don't need any input device allocation, but still they need to be registered as raw devices. Suggested-by: Sean Young Signed-off-by: Andi Shyti Reviewed-by: Sean Young --- drivers/media/rc/rc-main.c | 42 +++++++++++++++++++++++++----------------- include/media/rc-core.h | 9 ++++++--- 2 files changed, 31 insertions(+), 20 deletions(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 59fac96..1ddecca 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -1365,20 +1365,24 @@ struct rc_dev *rc_allocate_device(enum rc_driver_type type) if (!dev) return NULL; - dev->input_dev = input_allocate_device(); - if (!dev->input_dev) { - kfree(dev); - return NULL; - } + if (type != RC_DRIVER_IR_RAW_TX) { + dev->input_dev = input_allocate_device(); + if (!dev->input_dev) { + kfree(dev); + return NULL; + } + + dev->input_dev->getkeycode = ir_getkeycode; + dev->input_dev->setkeycode = ir_setkeycode; + input_set_drvdata(dev->input_dev, dev); - dev->input_dev->getkeycode = ir_getkeycode; - dev->input_dev->setkeycode = ir_setkeycode; - input_set_drvdata(dev->input_dev, dev); + setup_timer(&dev->timer_keyup, ir_timer_keyup, + (unsigned long)dev); - spin_lock_init(&dev->rc_map.lock); - spin_lock_init(&dev->keylock); + spin_lock_init(&dev->rc_map.lock); + spin_lock_init(&dev->keylock); + } mutex_init(&dev->lock); - setup_timer(&dev->timer_keyup, ir_timer_keyup, (unsigned long)dev); dev->dev.type = &rc_dev_type; dev->dev.class = &rc_class; @@ -1507,7 +1511,7 @@ static int rc_setup_rx_device(struct rc_dev *dev) static void rc_free_rx_device(struct rc_dev *dev) { - if (!dev) + if (!dev || dev->driver_type == RC_DRIVER_IR_RAW_TX) return; ir_free_table(&dev->rc_map); @@ -1537,7 +1541,8 @@ int rc_register_device(struct rc_dev *dev) atomic_set(&dev->initialized, 0); dev->dev.groups = dev->sysfs_groups; - dev->sysfs_groups[attr++] = &rc_dev_protocol_attr_grp; + if (dev->driver_type != RC_DRIVER_IR_RAW_TX) + dev->sysfs_groups[attr++] = &rc_dev_protocol_attr_grp; if (dev->s_filter) dev->sysfs_groups[attr++] = &rc_dev_filter_attr_grp; if (dev->s_wakeup_filter) @@ -1555,11 +1560,14 @@ int rc_register_device(struct rc_dev *dev) dev->input_name ?: "Unspecified device", path ?: "N/A"); kfree(path); - rc = rc_setup_rx_device(dev); - if (rc) - goto out_dev; + if (dev->driver_type != RC_DRIVER_IR_RAW_TX) { + rc = rc_setup_rx_device(dev); + if (rc) + goto out_dev; + } - if (dev->driver_type == RC_DRIVER_IR_RAW) { + if (dev->driver_type == RC_DRIVER_IR_RAW || + dev->driver_type == RC_DRIVER_IR_RAW_TX) { if (!raw_init) { request_module_nowait("ir-lirc-codec"); raw_init = true; diff --git a/include/media/rc-core.h b/include/media/rc-core.h index ba92c86..e6cb336 100644 --- a/include/media/rc-core.h +++ b/include/media/rc-core.h @@ -32,13 +32,16 @@ do { \ /** * enum rc_driver_type - type of the RC output * - * @RC_DRIVER_SCANCODE: Driver or hardware generates a scancode - * @RC_DRIVER_IR_RAW: Driver or hardware generates pulse/space sequences. - * It needs a Infra-Red pulse/space decoder + * @RC_DRIVER_SCANCODE: Driver or hardware generates a scancode + * @RC_DRIVER_IR_RAW: Driver or hardware generates pulse/space sequences. + * It needs a Infra-Red pulse/space decoder + * @RC_DRIVER_IR_RAW_TX: Device transmitter only, + * driver requires pulse/space data sequence. */ enum rc_driver_type { RC_DRIVER_SCANCODE = 0, RC_DRIVER_IR_RAW, + RC_DRIVER_IR_RAW_TX, }; /** -- 2.10.2