From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754011AbcLNTCu (ORCPT ); Wed, 14 Dec 2016 14:02:50 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33789 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753897AbcLNTCt (ORCPT ); Wed, 14 Dec 2016 14:02:49 -0500 Date: Wed, 14 Dec 2016 20:02:15 +0100 From: Michal Hocko To: kbuild test robot Cc: kbuild-all@01.org, Andrew Morton , Vlastimil Babka , David Rientjes , Johannes Weiner , linux-mm@kvack.org, LKML Subject: Re: [PATCH 1/3] mm, trace: extract COMPACTION_STATUS and ZONE_TYPE to a common header Message-ID: <20161214190215.GE16763@dhcp22.suse.cz> References: <20161214145324.26261-2-mhocko@kernel.org> <201612150127.1D06IAf6%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201612150127.1D06IAf6%fengguang.wu@intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 15-12-16 01:32:06, kbuild test robot wrote: > Hi Michal, > > [auto build test ERROR on tip/perf/core] > [also build test ERROR on v4.9 next-20161214] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Michal-Hocko/mm-oom-add-oom-detection-tracepoints/20161214-231225 > config: x86_64-randconfig-s2-12142134 (attached as .config) > compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > All error/warnings (new ones prefixed by >>): > > In file included from include/trace/trace_events.h:361, > from include/trace/define_trace.h:95, > from include/trace/events/compaction.h:356, > from mm/compaction.c:43: > include/trace/events/compaction.h: In function 'trace_raw_output_mm_compaction_end': > >> include/trace/events/compaction.h:134: error: expected expression before ',' token > include/trace/events/compaction.h: In function 'trace_raw_output_mm_compaction_suitable_template': > include/trace/events/compaction.h:195: error: expected expression before ',' token > >> include/trace/events/compaction.h:195: warning: missing braces around initializer > include/trace/events/compaction.h:195: warning: (near initialization for 'symbols[0]') > >> include/trace/events/compaction.h:195: error: initializer element is not constant > include/trace/events/compaction.h:195: error: (near initialization for 'symbols[0].mask') Interesting. I am pretty sure that my config battery has CONFIG_COMPACTION=n. Not sure which part of your config made a change. Anyway, I've added to my collection. And with the below diff it passes all my configs. --- >>From 921bf07b8684ded5f076904cc6baa875b52c3a1e Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Wed, 14 Dec 2016 18:56:44 +0100 Subject: [PATCH] fold me "mm, trace: extract COMPACTION_STATUS and ZONE_TYPE to a common header" 0-day has reported: In file included from include/trace/trace_events.h:361, from include/trace/define_trace.h:95, from include/trace/events/compaction.h:356, from mm/compaction.c:43: include/trace/events/compaction.h: In function 'trace_raw_output_mm_compaction_end': >> include/trace/events/compaction.h:134: error: expected expression before ',' token include/trace/events/compaction.h: In function 'trace_raw_output_mm_compaction_suitable_template': include/trace/events/compaction.h:195: error: expected expression before ',' token >> include/trace/events/compaction.h:195: warning: missing braces around initializer include/trace/events/compaction.h:195: warning: (near initialization for 'symbols[0]') >> include/trace/events/compaction.h:195: error: initializer element is not constant include/trace/events/compaction.h:195: error: (near initialization for 'symbols[0].mask') CONFIG_COMPACTION=n so COMPACTION_STATUS is not defined properly. Signed-off-by: Michal Hocko --- include/trace/events/compaction.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/trace/events/compaction.h b/include/trace/events/compaction.h index 2334faa56323..0a18ab6483ff 100644 --- a/include/trace/events/compaction.h +++ b/include/trace/events/compaction.h @@ -131,6 +131,7 @@ TRACE_EVENT(mm_compaction_begin, __entry->sync ? "sync" : "async") ); +#ifdef CONFIG_COMPACTION TRACE_EVENT(mm_compaction_end, TP_PROTO(unsigned long zone_start, unsigned long migrate_pfn, unsigned long free_pfn, unsigned long zone_end, bool sync, @@ -164,6 +165,7 @@ TRACE_EVENT(mm_compaction_end, __entry->sync ? "sync" : "async", __print_symbolic(__entry->status, COMPACTION_STATUS)) ); +#endif TRACE_EVENT(mm_compaction_try_to_compact_pages, @@ -192,6 +194,7 @@ TRACE_EVENT(mm_compaction_try_to_compact_pages, __entry->prio) ); +#ifdef CONFIG_COMPACTION DECLARE_EVENT_CLASS(mm_compaction_suitable_template, TP_PROTO(struct zone *zone, @@ -239,7 +242,6 @@ DEFINE_EVENT(mm_compaction_suitable_template, mm_compaction_suitable, TP_ARGS(zone, order, ret) ); -#ifdef CONFIG_COMPACTION DECLARE_EVENT_CLASS(mm_compaction_defer_template, TP_PROTO(struct zone *zone, int order), -- 2.10.2 -- Michal Hocko SUSE Labs