From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754082AbcLNUaH (ORCPT ); Wed, 14 Dec 2016 15:30:07 -0500 Received: from 216-12-86-13.cv.mvl.ntelos.net ([216.12.86.13]:58810 "EHLO brightrain.aerifal.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845AbcLNUaG (ORCPT ); Wed, 14 Dec 2016 15:30:06 -0500 Date: Wed, 14 Dec 2016 15:29:52 -0500 From: Rich Felker To: kernel-hardening@lists.openwall.com Cc: linux-kernel@vger.kernel.org Subject: Re: [kernel-hardening] [PATCH 3/4] Make static usermode helper binaries constant Message-ID: <20161214202952.GV1555@brightrain.aerifal.cx> References: <20161214185000.GA3930@kroah.com> <20161214185052.GC4939@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161214185052.GC4939@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2016 at 10:50:52AM -0800, Greg KH wrote: > > There are a number of usermode helper binaries that are "hard coded" in > the kernel today, so mark them as "const" to make it harder for someone > to change where the variables point to. You're not preventing change of where they point to, but rather preventing modification of the pointed-to data through these pointers... > Signed-off-by: Greg Kroah-Hartman > --- > drivers/macintosh/windfarm_core.c | 2 +- > drivers/net/hamradio/baycom_epp.c | 2 +- > drivers/pnp/pnpbios/core.c | 5 +++-- > drivers/staging/greybus/svc_watchdog.c | 4 ++-- > drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 6 +++--- > fs/nfsd/nfs4layouts.c | 6 ++++-- > security/keys/request_key.c | 7 ++++--- > 7 files changed, 18 insertions(+), 14 deletions(-) > > diff --git a/drivers/macintosh/windfarm_core.c b/drivers/macintosh/windfarm_core.c > index 465d770ab0bb..1b317cbb73cf 100644 > --- a/drivers/macintosh/windfarm_core.c > +++ b/drivers/macintosh/windfarm_core.c > @@ -74,7 +74,7 @@ static inline void wf_notify(int event, void *param) > > static int wf_critical_overtemp(void) > { > - static char * critical_overtemp_path = "/sbin/critical_overtemp"; > + static const char * critical_overtemp_path = "/sbin/critical_overtemp"; Should be static char *const critical_overtemp_path, or if you prefer static const char *const critical_overtemp_path (since the pointed-to data is not modifiable either). Likewise elsewhere. Rich