From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935463AbcLOIyb (ORCPT ); Thu, 15 Dec 2016 03:54:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:53923 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757506AbcLOIy2 (ORCPT ); Thu, 15 Dec 2016 03:54:28 -0500 Date: Thu, 15 Dec 2016 09:54:00 +0100 From: Johannes Thumshirn To: Dan Williams Cc: linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] libnvdimm, dax: replace mutex_is_locked() warnings with lockdep_assert_held Message-ID: <20161215085400.GB4561@linux-x5ow.site> References: <148178626605.29348.10608402287406082602.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <148178626605.29348.10608402287406082602.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2016 at 11:17:46PM -0800, Dan Williams wrote: > For warnings that should only ever trigger during development and > testing replace WARN statements with lockdep_assert_held. The lockdep > pattern is prevalent, and these paths are are well covered by libnvdimm > + dax unit tests. > > Reported-by: Johannes Thumshirn > Signed-off-by: Dan Williams > --- Thanks Dan, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850