From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759991AbcLPJKc (ORCPT ); Fri, 16 Dec 2016 04:10:32 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:63627 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759860AbcLPJKX (ORCPT ); Fri, 16 Dec 2016 04:10:23 -0500 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Arnd Bergmann , Walt Feasel , Bhumika Goyal , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: emxx_udc: remove incorrect __init annotations Date: Fri, 16 Dec 2016 10:09:39 +0100 Message-Id: <20161216091008.2329433-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:qlU5t6RH53WDVlRuGd6FebHGvz3fx4vLOhjUHIHQr+qTv2DWtOk JEhU6cdQXcs+ofoRGBPlY329tzjIvOS8DDBExrn7b1tXXL+87lNQZYFKvGaZGxxzZSHwxP5 rExa6HAwQfQ2+fbd0sfumqBAd4kc9x2iuypOwIfmIQCCwSoG6GGF1t5HRksDlmlJc7rgQMZ 5aCx9nn+sp7yFw4McRWZQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:xMpf+UiLoSQ=:MSe2rnGrTUYgb7yyXNi/lF rxl1spbuBLgOckAt/XHsiXNYVNRzTlu3A7W/kWGfzIe+lpYPvHMAyEQfSggueqXWXMLxuqO4b VZl4i9d8VUoqLybhsDAMaOywlXHo3I2WzY88oLmmtiwk6ELTCnW0+5xUMN9fdvOUhVuSchAFX DWO+aYvENbECRC3RkAbHNC1T5fYDPHnEiYF4qvRXcHsx7YZ/pzePlPbU5aGGQvZnEwRWVljAI ZUrXZ6vtCEgeMPbKWg1sQRc7u0X10hHBuWFqAbfU8norBKweHr+V9UjIYUmarFGnfiChtyoyH tCKDduf7/5jLil5Vcr1Fkb1tf7qCsbTvSVhI6FG+zPePI/JJezKAHXyuXCElU+4K/NTe+rvcU xO8Bc/izIOow2SgriiPLD1WNlKJIAF435g0NxCZujI03Egop0518B4TJwQs0ObEenNgkllSXj eLQcpgNu1BIn473DB65E2xu94cSBqW5xn/uS0WluQU0j6f9jlUV3SLO8EFWlAAj1+KhwNyiL+ 2TLaorRo7P/HFoyJkknryL8inmetoGoQ4EF/LEJV9vaQCfaMhr0Xwqo3T6ZnZa8+hotuoz+r5 GgxkhQ4DvTH1ykeAACkK/AG/rZDVyIoIy7FIqMfjW29cN/OJz7fJE6IVTvxgrUh/NHGVarL4t 7HLbm0mloSZNdFDtkT0HdVnzSqcNwTycsSQHJ+YR66F/iapCdXR8Edki4CkYTPl14m2s= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The probe function is not marked __init, but some other functions are. This leads to a warning on older compilers (e.g. gcc-4.3), and can cause executing freed memory when built with those compilers: WARNING: drivers/staging/emxx_udc/emxx_udc.o(.text+0x2d78): Section mismatch in reference from the function nbu2ss_drv_probe() to the function .init.text:nbu2ss_drv_contest_init() This removes the annotations. Fixes: 33aa8d45a4fe ("staging: emxx_udc: Add Emma Mobile USB Gadget driver") Signed-off-by: Arnd Bergmann --- drivers/staging/emxx_udc/emxx_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index 3f42fa8b0bf3..4a3da2406f48 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++ b/drivers/staging/emxx_udc/emxx_udc.c @@ -3137,7 +3137,7 @@ static const struct { }; /*-------------------------------------------------------------------------*/ -static void __init nbu2ss_drv_ep_init(struct nbu2ss_udc *udc) +static void nbu2ss_drv_ep_init(struct nbu2ss_udc *udc) { int i; @@ -3168,7 +3168,7 @@ static void __init nbu2ss_drv_ep_init(struct nbu2ss_udc *udc) /*-------------------------------------------------------------------------*/ /* platform_driver */ -static int __init nbu2ss_drv_contest_init( +static int nbu2ss_drv_contest_init( struct platform_device *pdev, struct nbu2ss_udc *udc) { -- 2.9.0