From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759650AbcLRCj2 (ORCPT ); Sat, 17 Dec 2016 21:39:28 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:47608 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752867AbcLRCj1 (ORCPT ); Sat, 17 Dec 2016 21:39:27 -0500 Date: Sat, 17 Dec 2016 21:39:24 -0500 (EST) Message-Id: <20161217.213924.1140198422054737923.davem@davemloft.net> To: arnd@arndb.de Cc: Yuval.Mintz@cavium.com, Ariel.Elior@cavium.com, everest-linux-l2@cavium.com, arun.easi@cavium.com, hare@suse.de, jthumshirn@suse.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] qed: fix old-style function definition From: David Miller In-Reply-To: <20161216084808.1815139-1-arnd@arndb.de> References: <20161216084808.1815139-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 17 Dec 2016 17:40:08 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Fri, 16 Dec 2016 09:47:41 +0100 > The newly added file causes a harmless warning, with "make W=1": > > drivers/net/ethernet/qlogic/qed/qed_iscsi.c: In function 'qed_get_iscsi_ops': > drivers/net/ethernet/qlogic/qed/qed_iscsi.c:1268:29: warning: old-style function definition [-Wold-style-definition] > > This makes it a proper prototype. > > Fixes: fc831825f99e ("qed: Add support for hardware offloaded iSCSI.") > Signed-off-by: Arnd Bergmann APplied.