From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760146AbcLRCrm (ORCPT ); Sat, 17 Dec 2016 21:47:42 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:47726 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754264AbcLRCrk (ORCPT ); Sat, 17 Dec 2016 21:47:40 -0500 Date: Sat, 17 Dec 2016 21:47:39 -0500 (EST) Message-Id: <20161217.214739.440356560135251249.davem@davemloft.net> To: sudipm.mukherjee@gmail.com Cc: sebastian.hesselbarth@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: mv643xx_eth: fix build failure From: David Miller In-Reply-To: <1481935505-24475-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1481935505-24475-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 17 Dec 2016 17:48:22 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sudip Mukherjee Date: Sat, 17 Dec 2016 00:45:05 +0000 > The build of sparc allmodconfig fails with the error: > "of_irq_to_resource" [drivers/net/ethernet/marvell/mv643xx_eth.ko] > undefined! > > of_irq_to_resource() is defined when CONFIG_OF_IRQ is defined. And also > CONFIG_OF_IRQ can only be defined if CONFIG_IRQ is defined. So we can > safely use #if defined(CONFIG_OF_IRQ) in the code. > > Signed-off-by: Sudip Mukherjee Applied, thanks.