From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759928AbcLRDM7 (ORCPT ); Sat, 17 Dec 2016 22:12:59 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:48126 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759478AbcLRDM6 (ORCPT ); Sat, 17 Dec 2016 22:12:58 -0500 Date: Sat, 17 Dec 2016 22:12:55 -0500 (EST) Message-Id: <20161217.221255.1870405962737594028.davem@davemloft.net> To: mike.kravetz@oracle.com Cc: sparclinux@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bob.picco@oracle.com, nitin.m.gupta@oracle.com, vijay.ac.kumar@oracle.com, julian.calaby@gmail.com, adam.buchbinder@gmail.com, kirill.shutemov@linux.intel.com, mhocko@suse.com, akpm@linux-foundation.org Subject: Re: [RFC PATCH 05/14] sparc64: Add PAGE_SHR_CTX flag From: David Miller In-Reply-To: <1481913337-9331-6-git-send-email-mike.kravetz@oracle.com> References: <1481913337-9331-1-git-send-email-mike.kravetz@oracle.com> <1481913337-9331-6-git-send-email-mike.kravetz@oracle.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 17 Dec 2016 18:13:39 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Kravetz Date: Fri, 16 Dec 2016 10:35:28 -0800 > @@ -166,6 +166,7 @@ bool kern_addr_valid(unsigned long addr); > #define _PAGE_EXEC_4V _AC(0x0000000000000080,UL) /* Executable Page */ > #define _PAGE_W_4V _AC(0x0000000000000040,UL) /* Writable */ > #define _PAGE_SOFT_4V _AC(0x0000000000000030,UL) /* Software bits */ > +#define _PAGE_SHR_CTX_4V _AC(0x0000000000000020,UL) /* Shared Context */ > #define _PAGE_PRESENT_4V _AC(0x0000000000000010,UL) /* Present */ > #define _PAGE_RESV_4V _AC(0x0000000000000008,UL) /* Reserved */ > #define _PAGE_SZ16GB_4V _AC(0x0000000000000007,UL) /* 16GB Page */ You really don't need this. The VMA is available, and you can obtain the information you need about whether this is a shared mapping or not from the. It just isn't being passed down into things like set_huge_pte_at(). Simply make it do so.