From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756707AbcLQNyQ (ORCPT ); Sat, 17 Dec 2016 08:54:16 -0500 Received: from merlin.infradead.org ([205.233.59.134]:49440 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbcLQNyP (ORCPT ); Sat, 17 Dec 2016 08:54:15 -0500 Date: Sat, 17 Dec 2016 14:54:11 +0100 From: Peter Zijlstra To: Darren Hart Cc: tglx@linutronix.de, mingo@kernel.org, juri.lelli@arm.com, rostedt@goodmis.org, xlpang@redhat.com, bigeasy@linutronix.de, linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, jdesfossez@efficios.com, bristot@redhat.com Subject: Re: [PATCH -v4 02/10] futex: Add missing error handling to FUTEX_REQUEUE_PI Message-ID: <20161217135411.GZ3107@twins.programming.kicks-ass.net> References: <20161213083638.938898295@infradead.org> <20161213085730.145521187@infradead.org> <20161217000639.GE62123@f23x64.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161217000639.GE62123@f23x64.localdomain> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 04:06:39PM -0800, Darren Hart wrote: > On Tue, Dec 13, 2016 at 09:36:40AM +0100, Peter Zijlstra wrote: > > Thomas spotted that fixup_pi_state_owner() can return errors and we > > fail to unlock the rt_mutex in that case. > > > > We handled this explicitly before Patch 1/10, so can this be rolled into 1/10 > (er 9) as a single commit? I don't think we did, see how this branch doesn't set pi_mutex.