From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758074AbcLRXb3 (ORCPT ); Sun, 18 Dec 2016 18:31:29 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:54781 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbcLRXb2 (ORCPT ); Sun, 18 Dec 2016 18:31:28 -0500 Date: Sun, 18 Dec 2016 15:31:29 -0800 From: Darren Hart To: Peter Zijlstra Cc: tglx@linutronix.de, mingo@kernel.org, juri.lelli@arm.com, rostedt@goodmis.org, xlpang@redhat.com, bigeasy@linutronix.de, linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, jdesfossez@efficios.com, bristot@redhat.com Subject: Re: [PATCH -v4 02/10] futex: Add missing error handling to FUTEX_REQUEUE_PI Message-ID: <20161218233129.GA71060@f23x64.localdomain> References: <20161213083638.938898295@infradead.org> <20161213085730.145521187@infradead.org> <20161217000639.GE62123@f23x64.localdomain> <20161217135411.GZ3107@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161217135411.GZ3107@twins.programming.kicks-ass.net> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 17, 2016 at 02:54:11PM +0100, Peter Zijlstra wrote: > On Fri, Dec 16, 2016 at 04:06:39PM -0800, Darren Hart wrote: > > On Tue, Dec 13, 2016 at 09:36:40AM +0100, Peter Zijlstra wrote: > > > Thomas spotted that fixup_pi_state_owner() can return errors and we > > > fail to unlock the rt_mutex in that case. > > > > > > > We handled this explicitly before Patch 1/10, so can this be rolled into 1/10 > > (er 9) as a single commit? > > I don't think we did, see how this branch doesn't set pi_mutex. > So it is, I stand corrected. So for 2/10 also then: Reviewed-by: Darren Hart -- Darren Hart Intel Open Source Technology Center