From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756194AbcLSPhV (ORCPT ); Mon, 19 Dec 2016 10:37:21 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:46340 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754968AbcLSPhU (ORCPT ); Mon, 19 Dec 2016 10:37:20 -0500 Date: Mon, 19 Dec 2016 10:37:12 -0500 (EST) Message-Id: <20161219.103712.1578523196484939315.davem@davemloft.net> To: madalin.bucur@nxp.com Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, scott.wood@nxp.com, mpe@ellerman.id.au Subject: Re: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[] From: David Miller In-Reply-To: <1482139343-8975-3-git-send-email-madalin.bucur@nxp.com> References: <1482139343-8975-1-git-send-email-madalin.bucur@nxp.com> <1482139343-8975-3-git-send-email-madalin.bucur@nxp.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 19 Dec 2016 06:37:58 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Madalin Bucur Date: Mon, 19 Dec 2016 11:22:20 +0200 > The fsl/fman drivers will use of_platform_populate() on all > supported platforms. > > Signed-off-by: Madalin Bucur It seems that this creates a failure point between patches #2 and #3. If the cases handled by this "fsl,fman" entry are only afterwards covered by the of_platform_populate() code added in patch #3 then you cannot split these two changes up like this. The two changes must be done at the same time, otherwise probing will fail for some people between patches #2 and #3.