From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754618AbcLSIMO (ORCPT ); Mon, 19 Dec 2016 03:12:14 -0500 Received: from mail-wj0-f193.google.com ([209.85.210.193]:33021 "EHLO mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751192AbcLSIMN (ORCPT ); Mon, 19 Dec 2016 03:12:13 -0500 Date: Mon, 19 Dec 2016 09:12:10 +0100 From: Michal Hocko To: Sergey Senozhatsky Cc: Vlastimil Babka , Andrew Morton , Mel Gorman , Johannes Weiner , Joonsoo Kim , linux-mm@kvack.org, LKML , Petr Mladek , Sergey Senozhatsky Subject: Re: [PATCH] mm: simplify node/zone name printing Message-ID: <20161219081210.GA32389@dhcp22.suse.cz> References: <20161216123232.26307-1-mhocko@kernel.org> <2094d241-f40b-2f21-b90b-059374bcd2c2@suse.cz> <20161219073228.GA1339@jagdpanzerIV.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161219073228.GA1339@jagdpanzerIV.localdomain> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 19-12-16 16:32:28, Sergey Senozhatsky wrote: [...] > as far as I can tell, now for_each_populated_zone() iterations are > split by non-CONT printk() from show_zone_node(), which previously > has been printk(KERN_CONT "%s: ", zone->name), so pr_cont(\n) > between iterations was important, but now that non-CONT printk() > should do the trick. it's _a bit_ hacky, though. Do you consider that more hacky than the original? At least for me, starting with KERN_CONT and relying on an explicit \n sounds more error prone than leaving the last pr_cont without \n and relying on the implicit flushing. -- Michal Hocko SUSE Labs