From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757640AbcLSJrs (ORCPT ); Mon, 19 Dec 2016 04:47:48 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:41106 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756985AbcLSJrp (ORCPT ); Mon, 19 Dec 2016 04:47:45 -0500 Date: Mon, 19 Dec 2016 10:47:36 +0100 From: Alexandre Belloni To: Geert Uytterhoeven Cc: Alessandro Zummo , Paul Cercueil , RTCLINUX , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] rtc: jz4740: make the driver builtin only Message-ID: <20161219094736.pa2o3xfxos66j7b4@piout.net> References: <20161109003753.29759-1-alexandre.belloni@free-electrons.com> <20161109003753.29759-2-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 19/12/2016 at 09:03:17 +0100, Geert Uytterhoeven wrote : > On Wed, Nov 9, 2016 at 1:37 AM, Alexandre Belloni > wrote: > > Since the driver is now calling machine_halt() that is not exported, it has > > to be built in the kernel. Building it as a module will fail at linking > > time. > > > > Signed-off-by: Alexandre Belloni > > --- > > drivers/rtc/Kconfig | 5 +---- > > drivers/rtc/rtc-jz4740.c | 10 +--------- > > 2 files changed, 2 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > > index 4259ce61c31b..24b0778f6e28 100644 > > --- a/drivers/rtc/Kconfig > > +++ b/drivers/rtc/Kconfig > > @@ -1550,15 +1550,12 @@ config RTC_DRV_MPC5121 > > will be called rtc-mpc5121. > > > > config RTC_DRV_JZ4740 > > - tristate "Ingenic JZ4740 SoC" > > + bool "Ingenic JZ4740 SoC" > > Just noticed RTC_DRV_JZ4740 flipped from m to y. > > This is bad for distribution kernels. > Can't the driver just call kernel_halt() instead of machine_halt()? > I'm not sure and I can't test. Paul, can you test? Maybe the other concern is that users that are not loading the rtc module will probably complain their machine is not powering off. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com