mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Sami Kerola <kerolasa@iki.fi>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: return EOPNOTSUPP when ioctl_fsthaw() is not supported
Date: Mon, 19 Dec 2016 02:24:02 -0800	[thread overview]
Message-ID: <20161219102402.GA24893@infradead.org> (raw)
In-Reply-To: <20161218185727.2209-1-kerolasa@iki.fi>

On Sun, Dec 18, 2016 at 06:57:27PM +0000, Sami Kerola wrote:
> An attempt to freeze a filesystem that does not support such operation is
> reported as EOPNOTSUPP to user.  Running unfreeze to the same filesystem
> returns EINVAL.  Later is a little misleading, users can mix that message
> with return value from unfreezing when filesystem is not frozen.

This is going to break gfs2 with it's odd ->that_super method.

  reply	other threads:[~2016-12-19 10:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-18 18:57 Sami Kerola
2016-12-19 10:24 ` Christoph Hellwig [this message]
2016-12-19 22:33   ` Sami Kerola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161219102402.GA24893@infradead.org \
    --to=hch@infradead.org \
    --cc=kerolasa@iki.fi \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome