From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759547AbcLSQGZ (ORCPT ); Mon, 19 Dec 2016 11:06:25 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:57236 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755459AbcLSQGX (ORCPT ); Mon, 19 Dec 2016 11:06:23 -0500 Date: Mon, 19 Dec 2016 08:05:44 -0800 From: Christoph Hellwig To: Nicolas Iooss Cc: Dave Chinner , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] xfs: silent -Wformat-security warning Message-ID: <20161219160544.GA9994@infradead.org> References: <20161219134111.5267-1-nicolas.iooss_linux@m4x.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161219134111.5267-1-nicolas.iooss_linux@m4x.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 19, 2016 at 02:41:11PM +0100, Nicolas Iooss wrote: > When building the XFS driver with clang, the compiler reports a > -Wformat-security warning in xlog_recover_validate_buf_type() because > xfs_warn() is being called with a non-literal string. Even though > variable warnmsg is always initialized as a constant string without any > '%' character, silent the warning by calling xfs_warn with "%s" format > string. > > Signed-off-by: Nicolas Iooss Looks fine: Reviewed-by: Christoph Hellwig