From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754348AbcLSWN5 (ORCPT ); Mon, 19 Dec 2016 17:13:57 -0500 Received: from mail-cys01nam02on0048.outbound.protection.outlook.com ([104.47.37.48]:48160 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752043AbcLSWNz (ORCPT ); Mon, 19 Dec 2016 17:13:55 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=syeh@vmware.com; Date: Mon, 19 Dec 2016 14:13:45 -0800 From: Sinclair Yeh To: Kees Cook CC: , VMware Graphics , Thomas Hellstrom , David Airlie , Subject: Re: [PATCH] drm/vmwgfx: use designated initializers Message-ID: <20161219221344.GA33820@promb-2n-dhcp338.eng.vmware.com> References: <20161217010402.GA140546@beast> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161217010402.GA140546@beast> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [208.91.1.34] X-ClientProxiedBy: MWHPR15CA0064.namprd15.prod.outlook.com (10.174.254.26) To MWHPR05MB3248.namprd05.prod.outlook.com (10.173.230.11) X-MS-Office365-Filtering-Correlation-Id: efd274fe-aae8-47a0-ff1d-08d4285c51f6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR05MB3248; X-Microsoft-Exchange-Diagnostics: 1;MWHPR05MB3248;3:oVp9INPv4dpeDLg4uD11n8GzwHAkHTaTq1ksk52tH9fTwBIUcezhl0YcPDl+NORBrmyKcIakv2uetvG/YuI7bKdSBjYCDrbwONdzObrlbRXXTctUhceqT52GvdTv+FtJYdj2zng6K6oynS6sOgu5DHUjmYLGp5O679HZXiSL4OBwzbamqfzLUNZYfUP7dd0I3rLxDnhoBGzBrVUaxm+vou3KF24Q+O61HjiblwNV3j7i3Bn/+AIRqf3XmtyQN3D6J6N78ik24w0SjPw6RDuBgQ==;25:tFXdVL97J8U7LapPTLwtzBYppPUrlwPDXCPWXwAzRB2oFItMky4qxJ5EzugqnV3TbVVWmqeJqeZpt/gv2VE7zasLD/ERh9/jkIYE1i1MYXP7Y7DISafJULjDMsPKZXT3lchhydTsUFNhP5ZCaAPP/BIVDkaH7u97aAQGm9z4edfcoa8bGqxtQq45HxQdEe6RjIt1O/6yzpQmJF8I/Qahjf/UNk7sGxFdZvtnZXj18qBtcs6wplalO/Mteu14rYEY5kmRcMQYG/Wxu6CmHWe8KA7REHpf7GZb8vatFvyHgd9tELEy8fRNrUmIY+w0UCcj8s+utry42qiH8g50lcjSk7TqKXG2vusCwM1dTovjip4MsucXcDfUGbShQmjev7eqZ//F0SUjwT+oI3vt0AnfZ06mW1PpaeMXHUzfVpCe0I/N4Ytfpzz9Tlztdd+O7Wh7bZUToSl0+gnhxYM1U1tj8A== X-Microsoft-Exchange-Diagnostics: 1;MWHPR05MB3248;31:NgoOJNdIA2J8vOVuCu9n2cCWL2Nm2fVYfYjuaZgMBZPA39m1n2SoWs8AFb1eU/06/pLVXAA45NF7aBU2oQhY+tGQxXtYiZMdhEJGW1TpLohZg8mKXBX3/zKg6VGNgh4Ll4kJSMg8k6S2saN1OrjjbMLJgiQBn0WyfdaFx6570oEPIU+JS5+SUOTB+aYCMGI+ff9AGU0wbqJSnBBgnQszjIeOIPeY89Uc3DDqiUtkwTj7rRz5vcDVuuAka0osXtKv;20:h9rWu/OBkbKMY3QNkVpkQTmVF2zHAeYAkFe3DOuFBhumAwsRpKxVgA62U8Zg0owELMWRs6z88MhRjFKjMKQt39mlGyXzsOR/G2oIw+zBcKKpm99b4z9oirPA64glVwvsmEe9ndlL0CKzTjYnrAVSegmgE95fjJaQVFIMsHBgvzLMQ1ER6C7JzYWcTC1dmeshabRTUwtN99OV2DOjbebzjvTRuUYRzRH3QLgnTHD/b/CYVdYVXZ9an9VCfa5GcnehDQKvE2o3yXTqMjzTNVXxDK/vk2LLddksKRQiQVWm4aTyGuz3rn+o1hkv90ZC0JWw7G++cRHknukNe6YGD8/ZIFl7qoeAXoUKIFfau6Cn7uKGr77O2X2Uh73gingF6CZFU+eKYY9ebBqlNlggklvZbkYnEFgx3O5ZA99HJZpL5WEO0BiSljnyXbCjS1gh5zC77d131z0euENWuuZha5mdTiJRV0PvqAzE+LGhGww2Ro9ECphnoRjarvGrEH+T/1Ra X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150)(192374486261705); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(6072148);SRVR:MWHPR05MB3248;BCL:0;PCL:0;RULEID:;SRVR:MWHPR05MB3248; X-Microsoft-Exchange-Diagnostics: 1;MWHPR05MB3248;4:9Qu1x6P8V6CTPPJVsqM85J8cYQZvO+/Yihu2QKd1lhLPUsnhwyZQVatlXxlQY4O1YjTf94yA5UrrMnItGYQWEfHNnRsyoF4i+u98cErHE+NCM+GFMwbpibwGk62G2rW1Pt8pfKVfOCkvulP6X4Hl5Bt3euJ+P2o9VJpJq0bhP6xzak+2zHxj7DgQFg3w+Z0756Pw/A7BXHDU3okl7zqqBVGE319hhsYTJTQsJ25awWHbZV+k80WhYjopOooBCD7qGya442O+/AzGwk115PoYKrFSi4sqHemL8yNToDVvYr/zWQ3Hek1DHWEChdP/5cMkuMBVueWbFHGCpWzoh7kvwgHY2iBRZd++UVBzYPslJlRsPFwZ0PXxFvH0xmcaEMPVdqhY5k3FMgEVHX9ji37gYJcbefjNZ1Gefup685JeX3FoK4cbhlWfrbDYWvMqKgQhUFVfyGGhYF9S3lLNfdCDwVAMC65nXfEFMTP2GYTAVm9Yw/RsdkWoswNsa/MTNKKjGRlVMLTTcU5e6OzT3r7CoLtcm6RnS0d8e3/qOErwn4MLGYR/rCkWeSqmmuqvLYUovUYkqGQStCE6dXYfBTNIYM49r1lkkM5Uzp3YTWl2u7zs+4tQk1KyWmxFPLg8vq3cpXGi/ol+EDv4EzSllm6sjQ== X-Forefront-PRVS: 01613DFDC8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(24454002)(199003)(189002)(92566002)(83506001)(50986999)(97736004)(101416001)(46406003)(50466002)(81156014)(2950100002)(86362001)(6666003)(33656002)(68736007)(81166006)(4001350100001)(110136003)(189998001)(8676002)(6916009)(54356999)(97756001)(4326007)(6116002)(23726003)(2906002)(3846002)(76176999)(25786008)(105586002)(1076002)(229853002)(47776003)(38730400001)(305945005)(106356001)(7736002)(42186005)(66066001)(5660300001)(7099028)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR05MB3248;H:promb-2n-dhcp338.eng.vmware.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR05MB3248;23:50kbWVeOx3xEvE3Tl1e8w5ZIdn9xoqMw7mbOaKabm?= =?us-ascii?Q?R0PpX9X4C9szYY3id5793bDIEiPkFJ4NOlFkDhQQ+7htpRNhjdhcIrFZJrhp?= =?us-ascii?Q?xmfiC3KhugLxR7Wv2JbksJ0dVlOF5fOj8iGOlp9fu1TCMjuJcT5ze3AJDuGG?= =?us-ascii?Q?2WPNvq5yJicZADrF/i7UyrTzJo0LZIqfH8LC0w+uzKrAX+8FMSahJWTj12uH?= =?us-ascii?Q?b4jkWdyyQZPZV1uEsi3R+6ITGtiLiDxCiWEDx9VEXpbrzQycQPjt1SQbTKy5?= =?us-ascii?Q?1De1Qm0HOwEM269Wj+B4/eu8P8Gr1qb+7Mo0jpLdzC7NV7Goqp6V1KoMF59l?= =?us-ascii?Q?H6QIt0PqlTiP7XmfAlqCh+2DcM4YHZu0+XE+NouSfwM335TiQim2nW3WHQjJ?= =?us-ascii?Q?nkXX0HobBa5Z7C0coljmQqbxtw+oiuGU2ErxTB1U9KQogSbx4fyCZkZtw8tz?= =?us-ascii?Q?A6qrgJ4Pys8wlwpgk6H17vSvgwV0ASAbcA889pCj2kl3JMkOgaj5CVNftHzE?= =?us-ascii?Q?rB1XZjSTfkF41t5bQF1CLFCNB7SrAkJzzuljzbErFaVqhqgf6zyex0pZr/vx?= =?us-ascii?Q?Ya2SINZPgGF7DrV1fwZaFrR85yeh/KuxzHfhhpD5Mwuqr8gyWOyqwUavKqC4?= =?us-ascii?Q?rTQVcc+5+oDnlLEd+IHOD48OSJLPOpfrnUYo/lJ7oa2czUWqjPpZC/olqs2r?= =?us-ascii?Q?EhEKjc29gUUmgpDUDGy/sIwZV9WrHkjXAVihKOmx6ky2FmGaWfbPJQkQjiRK?= =?us-ascii?Q?67+BtUlGPjqrr+EltHp7ozGItnB5hK+NjoRQ+Xv1O9Kq/I+CmEefEUiM3zSI?= =?us-ascii?Q?NZ/7klf8fqOigI1iUkkFfqSPScvUK1LT2gck+uGZnBDpK5FvR1B+ApPc05Nk?= =?us-ascii?Q?sfw/EnSNyvlTfguOTEyAWu2sVL5gdBO9dZfPOLZehxsnz3FUZ09ToBe03b1s?= =?us-ascii?Q?6Le1xH4ORKtFZvDCuN5Kw/3vahJltuNAY0aSa5N1oTrZSNybs9HlT887UdX2?= =?us-ascii?Q?wPwZYnIt5onW0Vsm8VnD/wO98X9uvabA3r/bTbgVGAe6kOr59VjDbAk9uMKw?= =?us-ascii?Q?hXa/1Vv8OfaApcOZ5yJ6qXUicqqeXBIGO1RCy6SCvrc1waFmAUPKfy9mTToP?= =?us-ascii?Q?ar791XIL2WLfedCm9qV3ikLBn9CeuZOJxel3pCCdPiKOxaCnotLXQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR05MB3248;6:25ivmk3Gz9Mlu0WflsZmlFrNBpj2s3owHmmKvJk6aEhE6aKiokFb6BOJ4R301yn793NE/ClAy/sC2wB82WNw5NAghQahXTJ9KmAyuBVOXkyFbg7BjfbpkXV+er5yMXOg9+0XebcFS1BZIuDHG7DZZzwrW3veE46yb/fNfnKLDS7F2yIDgVqvgjTowE4G+DZ1d6bGUo00JShnsYbYU7I+fQngiyrTkFh2x39cntIH+kpXiYfNNTO+3JsO5SGTeB9AD12gtcIxNAIbR3kUD58BEewmiVkOqhmpmsVg2/aMR3BlYIR23poP5nhP8NAxJH6RdyaqL4KNaIPy+VV+nu1Rwh7FHjhY53I4ZepWhMOSe3WBUWBCKIBbB9lPPzxayRC9REAo5qgZ8Sk+1rrqBIbBQgWzmrac+3i5buNzFuM4No8=;5:F+c+Ow8SrAVqSKH83nSwgPELyBQ4iaungXS9If2IYFVs5P9YCqil8xtXlykY6Q+Dyo4DFI406zH/r5DDptSrnaQyQ30BQNfE8AHL2guvRcCw4HrXiW5rsLXMPm44cXXXC+pyfXcD4q3iz8PQdO1gBA==;24:cbTQnSTzoMXvcv7ePjl8nu3WZS3KfS+ZJ8BBgeonCNClgHKOiK6Ys9GOyaVhO3Tm9611gKpc03U68yHJYy3cWcbSFFLHbFqyARH4JGjTaQk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR05MB3248;7:BFzDlpEJ4UknHwXFqL8YYT5TJdrd8JOi38mt9FoXSNjheaeV7Kud+mwG7j7GPF4ZMrgdDS3azXf1hY8h3HMQ9ZsWXGv2N330uI17h43yn6pz4gFmT2+LkqkcH+Pzdh5X+IGv7/+z9/rG59n0z5/E9HojE81229LdBYTnPRfs7NVHX94F8a0RDDIUgLeSRXKBDks3qv6gELl4V1anEJbMKhaDanTsjZWrgayOmqnVDOvrmQnMWvTmq/ME9LToo+VxGOZTpio3wV10nm/JqYmTrfMWGq7ahldSYv1dYALHhx6OwT9P/mwJFQqTWUebPmO+IFL+YTeJuPXMKBeyhlN+mZqQV+ohevYu6sokTa35c6A33OCH/W8ZRJVQkek8Ns6GTjca2Xs36g3if+sJtGa3WBLdRKhsZIbK1M2dM/nzj7jPqGTW9oX8KQ5OoJdZAwU7VRewEpH5vY8YONeRCBlKaA==;20:UCg1xUedUVvdUgg5eMST5Mf2yibzTtFESCyQ0DGW8eLpya/202DSLMz2xjOesuKTKBH2yoXC1IF3rsOBZ7DtNAIgvGBK8VuNwuRNHQjXgixXzsDFcY7/lPaTTpspFvOu8OBTyJsdaycyJOUTb6seGKMPIBh/ruWLC0IWjc22GLM= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2016 22:13:54.0484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR05MB3248 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Sinclair Yeh thanks! On Fri, Dec 16, 2016 at 05:04:02PM -0800, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook > --- > drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c > index 170b61be1e4e..fec7348cea2c 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c > @@ -164,9 +164,9 @@ static void vmw_gmrid_man_debug(struct ttm_mem_type_manager *man, > } > > const struct ttm_mem_type_manager_func vmw_gmrid_manager_func = { > - vmw_gmrid_man_init, > - vmw_gmrid_man_takedown, > - vmw_gmrid_man_get_node, > - vmw_gmrid_man_put_node, > - vmw_gmrid_man_debug > + .init = vmw_gmrid_man_init, > + .takedown = vmw_gmrid_man_takedown, > + .get_node = vmw_gmrid_man_get_node, > + .put_node = vmw_gmrid_man_put_node, > + .debug = vmw_gmrid_man_debug > }; > -- > 2.7.4 > > > -- > Kees Cook > Nexus Security