From: Michal Hocko <mhocko@kernel.org>
To: Thomas Casey <tqcasey@gmail.com>
Cc: akpm@linux-foundation.org, john.stultz@linaro.org,
tglx@linutronix.de, gorcunov@openvz.org,
nicolas.pitre@linaro.org, skinsbursky@virtuozzo.com,
mguzik@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: sys: fix out of place EXPORT_SYMBOL call
Date: Wed, 21 Dec 2016 07:49:50 +0100 [thread overview]
Message-ID: <20161221064950.GA16502@dhcp22.suse.cz> (raw)
In-Reply-To: <20161220143919.GA2334@loonix.localdomain>
On Tue 20-12-16 14:39:19, Thomas Casey wrote:
> Fixes two instances of EXPORT_SYMBOL not being called immediately after
> the initialization of its argument
What does this fix actually?
> Signed-off-by: Thomas Casey <tqcasey@gmail.com>
> ---
> kernel/sys.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/sys.c b/kernel/sys.c
> index 9758892a2d09..8afd3e341f9b 100644
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -110,9 +110,8 @@
> */
>
> int overflowuid = DEFAULT_OVERFLOWUID;
> -int overflowgid = DEFAULT_OVERFLOWGID;
> -
> EXPORT_SYMBOL(overflowuid);
> +int overflowgid = DEFAULT_OVERFLOWGID;
> EXPORT_SYMBOL(overflowgid);
>
> /*
> @@ -121,9 +120,8 @@ EXPORT_SYMBOL(overflowgid);
> */
>
> int fs_overflowuid = DEFAULT_FS_OVERFLOWUID;
> -int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
> -
> EXPORT_SYMBOL(fs_overflowuid);
> +int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
> EXPORT_SYMBOL(fs_overflowgid);
>
> /*
> --
> 2.11.0
>
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2016-12-21 7:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 14:39 Thomas Casey
2016-12-21 6:49 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221064950.GA16502@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=nicolas.pitre@linaro.org \
--cc=skinsbursky@virtuozzo.com \
--cc=tglx@linutronix.de \
--cc=tqcasey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®