From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764040AbcLVCbn (ORCPT ); Wed, 21 Dec 2016 21:31:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34970 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756391AbcLVCbm (ORCPT ); Wed, 21 Dec 2016 21:31:42 -0500 Date: Wed, 21 Dec 2016 19:31:40 -0700 From: Alex Williamson To: Jike Song Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 0/4] vfio-mdev: Clean namespace and better define ABI Message-ID: <20161221193140.6b3ddbb2@t450s.home> In-Reply-To: <585B3634.1050009@intel.com> References: <20161221232315.6091.30612.stgit@gimli.home> <585B3634.1050009@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 22 Dec 2016 02:31:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Dec 2016 10:11:00 +0800 Jike Song wrote: > On 12/22/2016 07:27 AM, Alex Williamson wrote: > > Cleanup the namespace a bit by prefixing structures with mdev_ and > > also more concretely define the mdev interface. Structs with comments > > defining which fields are private vs public tempts poor behavior, > > especially for an interface where we expect out of tree vendor drivers. > > Personally I like this series :) > > Side notes: 1) There is also Documentation to be updated; 2) your mail > address in Author field is @nuc.home? Thank you on both points, clearly I wrote these on something other than my usual system. Thanks, Alex > > > > --- > > > > Alex Williamson (4): > > vfio-mdev: Remove an unused structure element > > vfio-mdev: de-polute the namespace, rename parent_device & parent_ops > > vfio-mdev: Make mdev_parent private > > vfio-mdev: Make mdev_device private and abstract interfaces > > > > > > drivers/gpu/drm/i915/gvt/kvmgt.c | 22 +++++++------ > > drivers/vfio/mdev/mdev_core.c | 64 ++++++++++++++++++++++++++++++-------- > > drivers/vfio/mdev/mdev_private.h | 28 +++++++++++++++-- > > drivers/vfio/mdev/mdev_sysfs.c | 8 ++--- > > drivers/vfio/mdev/vfio_mdev.c | 12 ++++--- > > include/linux/mdev.h | 54 +++++++------------------------- > > samples/vfio-mdev/mtty.c | 28 +++++++++-------- > > 7 files changed, 123 insertions(+), 93 deletions(-) > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > >