From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761958AbcLVBcS (ORCPT ); Wed, 21 Dec 2016 20:32:18 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35922 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758434AbcLVBcQ (ORCPT ); Wed, 21 Dec 2016 20:32:16 -0500 Date: Thu, 22 Dec 2016 10:32:23 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky , Takashi Iwai , Hyeoncheol Lee , yjay.kim@lge.com, Sangseok Lee , Hugh Dickins , "[4.7+]" Subject: Re: [PATCH v4 2/3] zram: revalidate disk under init_lock Message-ID: <20161222013223.GD644@jagdpanzerIV.localdomain> References: <1482366980-3782-1-git-send-email-minchan@kernel.org> <1482366980-3782-3-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482366980-3782-3-git-send-email-minchan@kernel.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (12/22/16 09:36), Minchan Kim wrote: > [1] moved revalidate_disk call out of init_lock to avoid lockdep > false-positive splat. However, [2] remove init_lock in IO path > so there is no worry about lockdep splat. So, let's restore it. > This patch need to set BDI_CAP_STABLE_WRITES atomically in > next patch. > > [1] b4c5c60920e3: zram: avoid lockdep splat by revalidate_disk > [2] 08eee69fcf6b: zram: remove init_lock in zram_make_request > > Fixes: da9556a2367c ("zram: user per-cpu compression streams") > Cc: [4.7+] > Signed-off-by: Minchan Kim Reviewed-by: Sergey Senozhatsky -ss