From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941555AbcLVWrJ (ORCPT ); Thu, 22 Dec 2016 17:47:09 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:36405 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757041AbcLVWrH (ORCPT ); Thu, 22 Dec 2016 17:47:07 -0500 Date: Thu, 22 Dec 2016 16:47:04 -0600 From: Rob Herring To: Chris Packham Cc: linux-arm-kernel@lists.infradead.org, Mark Rutland , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] arm: mvebu: support for SMP on 98DX3336 SoC Message-ID: <20161222224704.6ikncsvb76y4zmfe@rob-hp-laptop> References: <20161222041328.3303-1-chris.packham@alliedtelesis.co.nz> <20161222041328.3303-3-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161222041328.3303-3-chris.packham@alliedtelesis.co.nz> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 22, 2016 at 05:13:25PM +1300, Chris Packham wrote: > Compared to the armada-xp the 98DX3336 uses different registers to set > the boot address for the secondary CPU so a new enable-method is needed. > This will only work if the machine definition doesn't define an overall > smp_ops because there is not currently a way of overriding this from the > device tree if it is set in the machine definition. Doesn't look like you documented the enable-method value. > Signed-off-by: Chris Packham > --- > .../bindings/arm/marvell/98dx3236-resume-ctrl.txt | 18 ++++++ > arch/arm/mach-mvebu/Makefile | 1 + > arch/arm/mach-mvebu/common.h | 1 + > arch/arm/mach-mvebu/platsmp.c | 43 ++++++++++++++ > arch/arm/mach-mvebu/pmsu-98dx3236.c | 69 ++++++++++++++++++++++ > 5 files changed, 132 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/marvell/98dx3236-resume-ctrl.txt > create mode 100644 arch/arm/mach-mvebu/pmsu-98dx3236.c