From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755354AbcLXPTB (ORCPT ); Sat, 24 Dec 2016 10:19:01 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35016 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752383AbcLXPTA (ORCPT ); Sat, 24 Dec 2016 10:19:00 -0500 Date: Sat, 24 Dec 2016 23:18:54 +0800 From: Geliang Tang To: Marek Vasut Cc: David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , Cyrille Pitchen , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: mtdswap: use MTDSWAP_ECNT_MIN/MAX Message-ID: <20161224151854.a3xxd6jdobjviuu2@ThinkPad> References: <254e9f859fdb1f850c1d3bd5777e97bf468b4e5a.1482225376.git.geliangtang@gmail.com> <252d763e-1767-9bf9-be1a-af0c02d4078f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <252d763e-1767-9bf9-be1a-af0c02d4078f@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 23, 2016 at 07:51:56PM +0100, Marek Vasut wrote: > On 12/20/2016 02:54 PM, Geliang Tang wrote: > > Since macros MTDSWAP_ECNT_MIN() and MTDSWAP_ECNT_MAX() have been > > defined in mtdswap.c, use them instead of open-coding. > > > > Signed-off-by: Geliang Tang > > Sorry for getting to this so late. The patch is fine, but if you grep > for 'rb_first' in the mtdswap driver , you'll see you can also use the > MTDSWAP_ECNT_MIN macro in mtdswap_map_free_block() and in > mtdswap_pick_gc_blk() . Can you fix those too ? Hi Marek, Thanks for your review. I double checked the code and found out that we can't use MTDSWAP_ECNT_MIN macro in mtdswap_map_free_block() and mtdswap_pick_gc_eblk(). Since the MTDSWAP_ECNT_MIN macro points to erase_count field of swap_eb, and erase_count field are not used in these two functions. Isn't it? -Geliang > > Otherwise: > Acked-by: Marek Vasut > > > --- > > drivers/mtd/mtdswap.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c > > index c40e2c9..f12879a 100644 > > --- a/drivers/mtd/mtdswap.c > > +++ b/drivers/mtd/mtdswap.c > > @@ -1235,10 +1235,8 @@ static int mtdswap_show(struct seq_file *s, void *data) > > > > if (root->rb_node) { > > count[i] = d->trees[i].count; > > - min[i] = rb_entry(rb_first(root), struct swap_eb, > > - rb)->erase_count; > > - max[i] = rb_entry(rb_last(root), struct swap_eb, > > - rb)->erase_count; > > + min[i] = MTDSWAP_ECNT_MIN(root); > > + max[i] = MTDSWAP_ECNT_MAX(root); > > } else > > count[i] = 0; > > } > > > > > -- > Best regards, > Marek Vasut